From: Felix Fietkau <nbd@nbd.name>
To: Aaro Koskinen <aaro.koskinen@iki.fi>,
Johannes Berg <johannes.berg@intel.com>,
Ryder Lee <ryder.lee@mediatek.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BISECTED REGRESSION] Wireless networking kernel crashes
Date: Sun, 21 Nov 2021 20:37:54 +0100 [thread overview]
Message-ID: <31021122-d1c1-181b-0b95-2ef1c1592452@nbd.name> (raw)
In-Reply-To: <20211118132556.GD334428@darkstar.musicnaut.iki.fi>
On 2021-11-18 14:25, Aaro Koskinen wrote:
> Hello,
>
> I have tried to upgrade my wireless AP (Raspberry Pi with rt2x00usb)
> from v5.9 to the current mainline, but now it keeps crashing every hour
> or so, basically making my wireless network unusable.
>
> I have bisected this to:
>
> commit 03c3911d2d67a43ad4ffd15b534a5905d6ce5c59
> Author: Ryder Lee <ryder.lee@mediatek.com>
> Date: Thu Jun 17 18:31:12 2021 +0200
>
> mac80211: call ieee80211_tx_h_rate_ctrl() when dequeue
>
> With the previous commit the system stays up for weeks...
>
> I just tried today's mainline, and it crashed after 10 minutes:
Please test if this patch fixes the issue:
---
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1822,15 +1822,15 @@ static int invoke_tx_handlers_late(struct ieee80211_tx_data *tx)
struct ieee80211_tx_info *info = IEEE80211_SKB_CB(tx->skb);
ieee80211_tx_result res = TX_CONTINUE;
+ if (!ieee80211_hw_check(&tx->local->hw, HAS_RATE_CONTROL))
+ CALL_TXH(ieee80211_tx_h_rate_ctrl);
+
if (unlikely(info->flags & IEEE80211_TX_INTFL_RETRANSMISSION)) {
__skb_queue_tail(&tx->skbs, tx->skb);
tx->skb = NULL;
goto txh_done;
}
- if (!ieee80211_hw_check(&tx->local->hw, HAS_RATE_CONTROL))
- CALL_TXH(ieee80211_tx_h_rate_ctrl);
-
CALL_TXH(ieee80211_tx_h_michael_mic_add);
CALL_TXH(ieee80211_tx_h_sequence);
CALL_TXH(ieee80211_tx_h_fragment);
next prev parent reply other threads:[~2021-11-21 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 13:25 [BISECTED REGRESSION] Wireless networking kernel crashes Aaro Koskinen
2021-11-21 10:14 ` Thorsten Leemhuis
2021-11-21 19:37 ` Felix Fietkau [this message]
2021-11-22 20:34 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31021122-d1c1-181b-0b95-2ef1c1592452@nbd.name \
--to=nbd@nbd.name \
--cc=aaro.koskinen@iki.fi \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).