From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29118C43217 for ; Thu, 1 Dec 2022 10:39:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230426AbiLAKji (ORCPT ); Thu, 1 Dec 2022 05:39:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230306AbiLAKj3 (ORCPT ); Thu, 1 Dec 2022 05:39:29 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7460E54B16 for ; Thu, 1 Dec 2022 02:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669891113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10Al1tSX1JNmT1W2eYBPU7HPfHOrdNXuqygGPStHWlc=; b=WytJe5b9dZZOf14CVQbSwOdtp4ZeLvSbTYtwvy+DKrArVSXU1aVTQ9H2pCTjU4rWVzA1NG 755nZrP2BN6DNJur/uUTxlu16/f4g7PHXMVnxmMZt9ZFonmW16FNjXhCAd2LPkhMi4IHfF eTkJkKTldV3WStqyHsDelQ4U6epU5jU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-489-OItugcUrM22L9OAoX-DE8g-1; Thu, 01 Dec 2022 05:38:32 -0500 X-MC-Unique: OItugcUrM22L9OAoX-DE8g-1 Received: by mail-wr1-f71.google.com with SMTP id e19-20020adfa453000000b0024209415034so284152wra.18 for ; Thu, 01 Dec 2022 02:38:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=10Al1tSX1JNmT1W2eYBPU7HPfHOrdNXuqygGPStHWlc=; b=t4/vgDkSU7gSOK6lkGFTWHuSllAcTcDt4hU6CsFhu6RKh+XMDHqEdMzWgJp+4YquTW QKvaDtPHquI+ygkzQbm6rvhhr2qtUC3S0HK7vL4fHSawfh50TCe8+YmQCRykJfON5nDH NZv2gorlE1ZQFvuIz+7GEFDGdiKYFKkhsCxJVKjQSnQ9XbnMI834+2Z20mSGCD0RBQ+8 5+U0EgCNyGJDQQCOxhZr4/vDDltOpnIKdMJ7RJ3VwP4oaM1PRmG1/xGxm3DXyUhkMkTM 8cWpDt6/xxvntmyK0jcuTdimFq5pTZM1GawlYw/hl7V3dXpWwDNcQHwmqy/OmieCCmmc Lqig== X-Gm-Message-State: ANoB5pn4ihNkTPV/aXqYyM2WIrtKSMpA2G6O1fYUjQhdi5HVMN8yUXq3 3VzUU+BUtLvkOpjoeb5SB92/9E98EnzeGJb49DbxjIjH3H2RKQe9IMLzkZw0xa+LjkefSGgP/Sz Z21/cqBXQuO/XUJii0hitTP5z X-Received: by 2002:a5d:43c9:0:b0:236:78d0:5223 with SMTP id v9-20020a5d43c9000000b0023678d05223mr41643015wrr.250.1669891111397; Thu, 01 Dec 2022 02:38:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf6KufTftndeSFnuJj0ww4Bi4u4dwK5MuxmTqCH6QTPyZEYTXUnzD5dmnVqEGF5aWgQYEpubqQ== X-Received: by 2002:a5d:43c9:0:b0:236:78d0:5223 with SMTP id v9-20020a5d43c9000000b0023678d05223mr41642998wrr.250.1669891111156; Thu, 01 Dec 2022 02:38:31 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id fc13-20020a05600c524d00b003d04e4ed873sm10098252wmb.22.2022.12.01.02.38.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Dec 2022 02:38:30 -0800 (PST) Message-ID: <31192e08-3d83-6fb0-06b0-51d50d073abc@redhat.com> Date: Thu, 1 Dec 2022 11:38:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 01/17] drm/tests: helpers: Move the helper header to include/drm Content-Language: en-US To: Maxime Ripard Cc: Daniel Vetter , Maarten Lankhorst , David Airlie , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Greg Kroah-Hartman , kunit-dev@googlegroups.com, linux-media@vger.kernel.org, linux-kselftest@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Brendan Higgins , =?UTF-8?Q?Ma=c3=adra_Canal?= , Dave Stevenson , linux-kernel@vger.kernel.org, David Gow References: <20221123-rpi-kunit-tests-v2-0-efe5ed518b63@cerno.tech> <20221123-rpi-kunit-tests-v2-1-efe5ed518b63@cerno.tech> <20221201102756.cdvxu4iryhu3rjpf@houat> From: Javier Martinez Canillas In-Reply-To: <20221201102756.cdvxu4iryhu3rjpf@houat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Maxime, On 12/1/22 11:27, Maxime Ripard wrote: [...] >> >> I wonder if now that this header was moved outside of the tests directory, >> if we should add stub functions in the header file that are just defined >> but do nothing if CONFIG_DRM_KUNIT_TEST isn't enabled. So that including >> it in drivers will be a no-op. >> >> Or do you plan to conditionally include this header file in drivers? So >> that is only included when CONFIG_DRM_KUNIT_TEST is enabled? > > I'm not entirely sure. I'd expect only the tests to include it, and thus > would depend on DRM_KUNIT_TEST already. But we can always add the stubs > if it's ever included in a different context. > >> Another thing that wondered is if we want a different namespace for this >> header, i.e: , to make it clear that is >> not part of the DRM API but just for testing helpers. > > If there's a single header, I don't think we need to create the > directory. This is also something we can consolidate later on if needed. > Agree on both. It's better to land as is and then figure out if needs to be changed once other drivers add more tests. >> But these are open questions really, and they can be done as follow-up: >> >> Reviewed-by: Javier Martinez Canillas > > Thanks :) You are welcome! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat