From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13D0A155304; Mon, 29 Jan 2024 16:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706544016; cv=none; b=lVV1Gcy99AQ7/CiGJxFRgi88si9ERyeTQXGY5nS3FIflJYqliWQTH5E+VSPQcYYitLzhjCEs7ONZ/eZQks0jVyUqfNk1tALWzEcgVBQnZ2SCqGNAkpQZ/j05KCQRKtQWjtXn1to9LEnmIkBvfSaA9ODru2zCD1OgFghRjF5QdYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706544016; c=relaxed/simple; bh=d6TFGi8BNctQDCOOatr9FnKfaGcVCb8rRipdC9S04zA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lvYOK9a9mCRbWIjEGm5C6tnFMaNwgThrQ4caiL0ywzj/KyxXpVt14l+WQEV428FvfRxLMjr642JRXzP2Jz9TmyoDu7k4I3G0IUjnDpq0PrcyF52jP/rikoJpGOMUhfiBSMHfJP80ZGZ//XkUJ9pMea9HHpw5ZstH5SxPKFPxh38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=eH5y4ydM; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="eH5y4ydM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1706544004; bh=d6TFGi8BNctQDCOOatr9FnKfaGcVCb8rRipdC9S04zA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eH5y4ydMRbjU95Ip5rq/FteulTBNtfQKx8mOIFp1ZYUmBoPKXEL40d2RlYMIfhbVx +TiWTWQ0BxCUziwp5QxjUncNLRFiqB5dptErtl+YbgRmL8yI2BmHrCTtVrZxhiC8Fg vT1kyFfHfAhPY0KG8ueGARoBM3M03Rb543NWzPz3SR0+2DqBH9nSU65sOcCREVE+89 n+wSkfoOcBNepLWJTEXGLl/ad+bd4DtyOKSEwmHj4QJ9oOVGZjTHOEo6YPVszVFRZo umqepby1hblCNj/hBrn66bW7B8Y7pR3uwo7moTgpoZ5nVFv38om2wIi9OL7rICI5tC oCqmB+19MyMag== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TNtKw3S5fzVXK; Mon, 29 Jan 2024 11:00:04 -0500 (EST) Message-ID: <3120f1f0-eaf8-4058-9a65-bdbee28c68c9@efficios.com> Date: Mon, 29 Jan 2024 11:00:04 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] eventfs: Have inodes have unique inode numbers Content-Language: en-US To: Linus Torvalds Cc: Steven Rostedt , LKML , Linux Trace Devel , Masami Hiramatsu , Christian Brauner , Ajay Kaher , Geert Uytterhoeven , linux-fsdevel References: <20240126150209.367ff402@gandalf.local.home> <20240126162626.31d90da9@gandalf.local.home> <8547159a-0b28-4d75-af02-47fc450785fa@efficios.com> <29be300d-00c4-4759-b614-2523864c074b@efficios.com> From: Mathieu Desnoyers In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-01-26 17:49, Linus Torvalds wrote: > On Fri, 26 Jan 2024 at 14:41, Mathieu Desnoyers > wrote: >> >> Yes, there is even a note about stat.st_size in inode(7) explaining >> this: > > Good. Send a patch to do the same for st_ino. This breaks "cp -aH" and "cp -aL". Even setting st_nlink={0,1} does not help there, from coreutils 9.1: copy_internal(): [...] else if (x->preserve_links && !x->hard_link && (1 < src_sb.st_nlink || (command_line_arg && x->dereference == DEREF_COMMAND_LINE_ARGUMENTS) || x->dereference == DEREF_ALWAYS)) { earlier_file = remember_copied (dst_relname, src_sb.st_ino, src_sb.st_dev); } Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com