LKML Archive on lore.kernel.org
 help / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: Sven Van Asbroeck <thesven73@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Lee Jones <lee.jones@linaro.org>,
	mark.rutland@arm.com, treding@nvidia.com,
	David Lechner <david@lechnology.com>,
	noralf@tronnes.org, johan@kernel.org,
	Michal Simek <monstr@monstr.eu>,
	michal.vokac@ysoft.com, Arnd Bergmann <arnd@arndb.de>,
	Greg KH <gregkh@linuxfoundation.org>,
	john.garry@huawei.com, geert+renesas@glider.be,
	robin.murphy@arm.com,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	sebastien.bourdelin@savoirfairelinux.com, icenowy@aosc.io,
	Stuart Yoder <stuyoder@gmail.com>,
	"J. Kiszka" <jan.kiszka@siemens.com>,
	maxime.ripard@bootlin.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v10 0/7] Add Fieldbus subsystem + support HMS Profinet card
Date: Wed, 17 Apr 2019 19:04:37 +0200
Message-ID: <31245f21-ae98-f10f-9484-a1719164ce16@suse.de> (raw)
In-Reply-To: <c1831703-a476-8870-0a5f-9060bda0f669@metux.net>

Hi Enrico,

Am 16.04.19 um 18:49 schrieb Enrico Weigelt, metux IT consult:
> On 15.04.19 20:31, Sven Van Asbroeck wrote:
>>> Maybe it would be better calling it "IEC-61158" instead of "fieldbus" ?>>> > Yes, we are certainly open to that, if it is more correct and/or
> better> accepted by users.
> Thanks, I'd really appreciate that :)
> 
> Maybe I'm a bit beaurocratic here, but I really believe that precise
> naming is important, eg. for avoiding potential conflicts w/ different
> fieldbus classes (eg. mvb) that might come in the future.

I somewhat see your point, but I would not have recognized iec61158 as
something relevant to my hardware, whereas fieldbus is understandable.

If you see specific conflicts or differences, please explain them
instead of just throwing around bus names. :) Then we can more easily
discuss whether to make changes to this framework or whether we indeed
need some fieldbus/iec61158/ subdirectory. For your RS-485 I don't see a
conflict as that'll just go via tty/serial/ and optionally serdev, no?
However, I'd be curious how I/O Link might relate to this, it seems to
have no public specifications.

> By the way: any special reason for doing this via device instead of
> socket (like we have w/ can) ?
> 
> I'm, personally, pretty undecided which way is better. Device nodes give
> us easy access control via fs permissions, while socket allows
> firewalling.

While I do like sockets, they seem more useful for packet-based
communication, which may be an implementation detail of fieldbus_dev
drivers, but AFAIU that's unrelated to Sven's memory-focused subsystem
representing a view of the data received, which may be different from
the last packet received. Also, when a packet is received via socket, it
gets dequeued, whereas you'll want to access the device's memory without
restrictions.

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

  parent reply index

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 14:42 Sven Van Asbroeck
2019-04-09 14:42 ` [PATCH v10 1/7] fieldbus_dev: add Fieldbus Device subsystem Sven Van Asbroeck
2019-04-16 11:13   ` Greg KH
2019-04-09 14:42 ` [PATCH v10 2/7] anybus-s: support HMS Anybus-S bus Sven Van Asbroeck
2019-04-09 14:42 ` [PATCH v10 3/7] anybus-s: support the Arcx anybus controller Sven Van Asbroeck
2019-04-09 14:42 ` [PATCH v10 4/7] dt-bindings: anybus-controller: document devicetree binding Sven Van Asbroeck
2019-04-09 15:50   ` Rob Herring
2019-04-09 17:16     ` Sven Van Asbroeck
2019-04-09 17:31       ` Sven Van Asbroeck
2019-04-09 21:09         ` Rob Herring
2019-04-10 13:11           ` Sven Van Asbroeck
2019-04-16 11:11             ` Greg KH
2019-04-09 14:42 ` [PATCH v10 5/7] dt-bindings: Add vendor prefix for arcx / Archronix Sven Van Asbroeck
2019-04-09 14:42 ` [PATCH v10 6/7] fieldbus_dev: support HMS Profinet IRT industrial controller Sven Van Asbroeck
2019-04-09 14:42 ` [PATCH v10 7/7] staging: fieldbus_dev: add TODO Sven Van Asbroeck
2019-04-15 17:41 ` [PATCH v10 0/7] Add Fieldbus subsystem + support HMS Profinet card Enrico Weigelt, metux IT consult
2019-04-15 18:31   ` Sven Van Asbroeck
2019-04-16 16:49     ` Enrico Weigelt, metux IT consult
2019-04-16 18:56       ` Sven Van Asbroeck
2019-04-16 21:18         ` Enrico Weigelt, metux IT consult
2019-04-16 21:49           ` Sven Van Asbroeck
2019-04-16 22:12           ` Sven Van Asbroeck
2019-04-18  8:32             ` Enrico Weigelt, metux IT consult
2019-04-18 17:34               ` Sven Van Asbroeck
2019-04-17 14:37           ` Sven Van Asbroeck
2019-04-17 17:04       ` Andreas Färber [this message]
2019-04-17 20:13         ` Enrico Weigelt, metux IT consult

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31245f21-ae98-f10f-9484-a1719164ce16@suse.de \
    --to=afaerber@suse.de \
    --cc=arnd@arndb.de \
    --cc=david@lechnology.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=icenowy@aosc.io \
    --cc=jan.kiszka@siemens.com \
    --cc=johan@kernel.org \
    --cc=john.garry@huawei.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@metux.net \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=michal.vokac@ysoft.com \
    --cc=monstr@monstr.eu \
    --cc=netdev@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sebastien.bourdelin@savoirfairelinux.com \
    --cc=stuyoder@gmail.com \
    --cc=thesven73@gmail.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox