From: "Jernej Škrabec" <firstname.lastname@example.org>
To: Chen-Yu Tsai <email@example.com>
Cc: Maxime Ripard <firstname.lastname@example.org>,
Rob Herring <email@example.com>,
Mark Rutland <firstname.lastname@example.org>,
Mauro Carvalho Chehab <email@example.com>,
Linux Media Mailing List <firstname.lastname@example.org>,
Subject: Re: [PATCH 1/3] media: dt: bindings: sunxi-ir: Add A64 compatible
Date: Mon, 21 Jan 2019 18:33:19 +0100 [thread overview]
Message-ID: <3128239.8RYQUhiYef@jernej-laptop> (raw)
Dne ponedeljek, 21. januar 2019 ob 10:57:57 CET je Chen-Yu Tsai napisal(a):
> On Mon, Jan 21, 2019 at 5:50 PM Maxime Ripard <email@example.com>
> > Hi,
> > I'm a bit late to the party, sorry for that.
> > On Sat, Jan 12, 2019 at 09:56:11AM +0800, Chen-Yu Tsai wrote:
> > > On Sat, Jan 12, 2019 at 1:30 AM Jernej Skrabec <firstname.lastname@example.org>
> > > > A64 IR is compatible with A13, so add A64 compatible with A13 as a
> > > > fallback.
> > >
> > > We ask people to add the SoC-specific compatible as a contigency,
> > > in case things turn out to be not so "compatible".
> > >
> > > To be consistent with all the other SoCs and other peripherals,
> > > unless you already spotted a "compatible" difference in the
> > > hardware, i.e. the hardware isn't completely the same, this
> > > patch isn't needed. On the other hand, if you did, please mention
> > > the differences in the commit log.
> > Even if we don't spot things, since we have the stable DT now, if we
> > ever had that compatible in the DT from day 1, it's much easier to
> > deal with.
> > I'd really like to have that pattern for all the IPs even if we didn't
> > spot any issue, since we can't really say that the datasheet are
> > complete, and one can always make a mistake and overlook something.
> > I'm fine with this version, and can apply it as is if we all agree.
> I'm OK with having the fallback compatible. I'm just pointing out
> that there are and will be a whole bunch of them, and we don't need
> to document all of them unless we are actually doing something to
> support them.
If you don't document them, checkpatch will complain. But if you can live with
this warning, that's fine by me.
> On the other hand, the compatible string situation for IR needs a
> bit of cleaning up at the moment. Right now we have sun4i-a10 and
> sun5i-a13. As Jernej pointed out, the A13's register definition is
> different from A64 (or any other SoCs later than sun6i). So we need
> someone with an A10s/A13 device that has IR to test it and see if
> the driver or the manual is wrong, and we'd likely add a compatible
> for the A20.
> Also, the earlier SoCs (A10/sun5i/A20) have IR TX capability. This
> was lost in A31, and also all of sun8i / sun50i. So we're going to
> need to add an A31 compatible that all later platforms would need
> to switch to.
H6 has IR TX peripheral too, but it's different IP block...
Do you want me to switch all A31 and newer to different compatible in this
series? I can do this, but I haven't any A13 device to test if this is really
needed. Or you can argue that this is needed anyway due to missing TX
next prev parent reply other threads:[~2019-01-21 17:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 17:30 [PATCH 0/3] Add support for IR on Allwinner A64 Jernej Skrabec
2019-01-11 17:30 ` [PATCH 1/3] media: dt: bindings: sunxi-ir: Add A64 compatible Jernej Skrabec
2019-01-12 1:56 ` Chen-Yu Tsai
2019-01-12 8:08 ` Jernej Škrabec
2019-01-21 9:50 ` Maxime Ripard
2019-01-21 9:57 ` Chen-Yu Tsai
2019-01-21 17:33 ` Jernej Škrabec [this message]
2019-01-21 17:39 ` Chen-Yu Tsai
2019-01-21 17:59 ` Jernej Škrabec
2019-01-22 0:19 ` Rob Herring
2019-01-22 2:16 ` Chen-Yu Tsai
2019-01-22 13:37 ` Rob Herring
2019-01-25 2:29 ` Chen-Yu Tsai
2019-01-24 18:56 ` Jernej Škrabec
2019-01-25 2:49 ` Chen-Yu Tsai
2019-01-25 15:51 ` Maxime Ripard
2019-01-11 17:30 ` [PATCH 2/3] arm64: dts: allwinner: a64: Add IR node Jernej Skrabec
2019-01-11 17:30 ` [PATCH 3/3] arm64: dts: allwinner: a64: Orange Pi Win: Enable IR Jernej Skrabec
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).