On 04/06/18 09:13, Maxime Ripard wrote: > On Sat, Jun 02, 2018 at 05:03:13PM +0100, Bob Ham wrote: >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. > And this is redundant with the SPDX header. The X11 license notice states explicitly that the notice has to be included in the file. Wouldn't removing it be a violation of the license? >> + brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; > > Each step should increase the perceived brightness by roughly 1/Nth, N > being the number of steps. Usually PWM backlights don't work like that. FYI, this was copied from another .dts file. All of the other brightness-levels settings in sun{4,5,7}i .dts files follow similar patterns: sun4i-a10-dserve-dsrv9703c.dts: brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; sun4i-a10-inet1.dts: brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; sun4i-a10-pov-protab2-ips9.dts: brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; sun5i-a13-empire-electronix-d709.dts: brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; sun5i-a13-utoo-p66.dts: brightness-levels = <0 30 40 50 60 70 80 90 100>; sun5i-gr8-evb.dts: brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; sun7i-a20-wexler-tab7200.dts: brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; I'll take the brightness-levels from sun8i-a83t-tbs-a711.dts which follows a more appropriate pattern: sun8i-a83t-tbs-a711.dts: brightness-levels = <0 1 2 4 8 16 32 64 128 255>; Thanks, Bob -- Bob Ham for (;;) { ++pancakes; }