From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436AbcLIUnD (ORCPT ); Fri, 9 Dec 2016 15:43:03 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:59777 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037AbcLIUnC (ORCPT ); Fri, 9 Dec 2016 15:43:02 -0500 From: Arnd Bergmann To: Bjorn Andersson Cc: Ohad Ben-Cohen , Srinivas Kandagatla , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: qcom_adsp_pil: select qcom_scm Date: Fri, 09 Dec 2016 21:42:55 +0100 Message-ID: <3141429.Gm13CfGpJK@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20161209192310.GY30492@tuxbot> References: <20161209114730.3780719-1-arnd@arndb.de> <20161209192310.GY30492@tuxbot> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:XrZqfgkVraIttFz+d6UibAe0W8vnomLtAUk9ye8HpMPpkwn6NOi arwqNgzZn5xyXWAZTvvYDIleWbUOIqxeXb+ifh4GH85DKmxRivuSS89zzU1sOFy3ccRD2R1 BUyyge5mYvCZMCeFwzFGIHBQYiMh9YtSTQCAeDdAy6/LhnU+uruZcwnjtbYcmA3YHsAvYHt kUfKSVUxiNev8lj7EglKw== X-UI-Out-Filterresults: notjunk:1;V01:K0:r+13CccWF90=:oYeIfA5p0sdcFiiTFGU5XM G0vrQVFYB1n3c2hqBTHh8YGk6csMo9iWOj6DE5uJ3Yv9AuNtY3Cf5mM22rlMIUQymI4QLlTKZ CPvWR4s/j94l5NpDScnPf5AV+/avuBgdMiRHUirFN64GGebmdqTqte2TygLNibIKf2vxeVOMz Qq9//DQmeDuDWgTW05IC6rJ45cPsB9igx93WOg1+ATbNWonBg7E4CsfBxVYutM/41HVs2GIyP FOsHE86hCDRep34kp2Fp8v3RO4V7iS+O7p6LPZAgceZlmNmEPYOEiAWehu5tN/VZivAnV6aF+ Sj1jkq6GFSY7ZkXxfMd1D66E7Lo/SYT6XWHbMbFihVaX9lKf9FFJQI1HARPEllnhkRgTmpVAU VJOnFWIGOqmKx1fLhLPWXXlSwnTDIW1URtNKXDH4v8OsZ9cOkVOV9RjxxwhbgOlNN9YSxxkkz hxSr6BRrcjpFZaVm3/Kn+z6SZIGM17MkD9t5Ms2tsrtFNOvZ2RMTUP5wxSnzL8HZMKEArIK4j gBDWZ3SKZ5w0cWvCGdHTCj5ldn6/taDaEYwuCX22a6kh4HZEkKa4HtAbosK/gF34LEEHvL/lO V3ejvtC4uFiBmIsUuT4uOQCD3h06BRZ2pGM5/ijv9U5cdftOl4OLThAkbn/BdAPjFmmRLe0L8 ViSUFkrtbE7M/vEP3i/BD52Hij2uuq8WGBZcIouNetx4bSdLRE/1dhGg35QtcuvSrlThzQDYU 4NRK94ZXbfNYXHn0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, December 9, 2016 11:23:10 AM CET Bjorn Andersson wrote: > On Fri 09 Dec 03:47 PST 2016, Arnd Bergmann wrote: > > > The adsp-pil driver relies on SCM and causes a build error without it: > > > > ERROR: "qcom_scm_pas_supported" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > > ERROR: "qcom_scm_is_available" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > > ERROR: "qcom_scm_pas_auth_and_reset" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > > ERROR: "qcom_scm_pas_shutdown" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > > ERROR: "qcom_scm_pas_mem_setup" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > > ERROR: "qcom_scm_pas_init_image" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > > > > This adds a 'select', as SCM is a silent Kconfig symbol that gets > > enabled implicitly by all its users. > > > > Thanks, sorry for giving you the opportunity for finding all these odd > combinations. > > Are you aware of any projects aiming to catch these through e.g. > dependency analysis rather than random build testing (and my now growing > manual checklist)? I think there is one project that tries to identify impossible constraints in Kconfig, but that would not have caught cases like this one. Arnd