From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AA4C5ACBF for ; Fri, 13 Mar 2020 13:40:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C89172073E for ; Fri, 13 Mar 2020 13:40:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="ezSTBR35" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbgCMNkO (ORCPT ); Fri, 13 Mar 2020 09:40:14 -0400 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:59826 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726695AbgCMNkL (ORCPT ); Fri, 13 Mar 2020 09:40:11 -0400 Received: from mailhost.synopsys.com (mdc-mailhost2.synopsys.com [10.225.0.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 194E1C0FB0; Fri, 13 Mar 2020 13:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1584106810; bh=rcAqQ1O33U21fdLUgojPBeEA9JnctLvnhRjalBTBl+k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=ezSTBR352SeEGsPvGI0WubGZdMMH5XD853Ubuzb7afYnuzVU6VrXVLmLMqJrXV5/u tOCaQe84PFjz3yoyqzuMYcOKU3wkiVggZ+QONvQbm6ZdI34cWF7gxcsEvOy5QEd01V o7BcPS51EzO9fxsfUUE4WXh0dLFmOWm4w3kqp/WggMEi/jV2O1cjDXUy10VlaflYDH sTmQ85f+dXXbFo7ZGZYeTG7DuF4qBCXJohhjPKIER5zyreZGYCmo7WQDXKVE3DJIE5 8pdeXdP/1Y+7hWqvHaK5IMW0FFzRKy1p3dk1Ch6r33bPFC7SNTShZI8Y0Z7QGePkIM 6F8wqropPUiag== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 8D0ACA0064; Fri, 13 Mar 2020 13:40:08 +0000 (UTC) From: Jose Abreu To: netdev@vger.kernel.org Cc: Joao Pinto , Jose Abreu , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , "David S. Miller" , linux-kernel@vger.kernel.org Subject: [PATCH net-next 3/4] net: phy: xpcs: Return error when 10GKR link errors are found Date: Fri, 13 Mar 2020 14:39:42 +0100 Message-Id: <314512a6938e6472237b55753b04ec83177111b2.1584106347.git.Jose.Abreu@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For 10GKR rate, when link errors are found we need to return fault status so that XPCS is correctly resumed. Signed-off-by: Jose Abreu --- Cc: Jose Abreu Cc: Andrew Lunn Cc: Florian Fainelli Cc: Heiner Kallweit Cc: Russell King Cc: "David S. Miller" Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/phy/mdio-xpcs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio-xpcs.c b/drivers/net/phy/mdio-xpcs.c index 23516397b982..83ced7180a44 100644 --- a/drivers/net/phy/mdio-xpcs.c +++ b/drivers/net/phy/mdio-xpcs.c @@ -219,8 +219,10 @@ static int xpcs_read_fault(struct mdio_xpcs_args *xpcs, if (ret < 0) return ret; - if (ret & MDIO_PCS_10GBRT_STAT2_ERR) + if (ret & MDIO_PCS_10GBRT_STAT2_ERR) { xpcs_warn(xpcs, state, "Link has errors!\n"); + return -EFAULT; + } return 0; } -- 2.7.4