From: David Howells <dhowells@redhat.com>
To: Nayna Jain <nayna@linux.vnet.ibm.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH 1/3] certs: define a trusted platform keyring
Date: Wed, 07 Mar 2018 16:03:18 +0000 [thread overview]
Message-ID: <31489.1520438598@warthog.procyon.org.uk> (raw)
In-Reply-To: <20180228175521.10287-1-nayna@linux.vnet.ibm.com>
Nayna Jain <nayna@linux.vnet.ibm.com> wrote:
> + key = key_create_or_update(make_key_ref(keyring, 1),
> + "asymmetric",
> + NULL,
> + p,
> + plen,
> + ((KEY_POS_ALL & ~KEY_POS_SETATTR) |
> + KEY_USR_VIEW | KEY_USR_READ),
> + KEY_ALLOC_NOT_IN_QUOTA |
> + KEY_ALLOC_BUILT_IN |
> + KEY_ALLOC_BYPASS_RESTRICTION);
There's no need to reindent here. Please line up all the arguments: either
push the first argument over onto the next line if you need to or line them
all up with the char after the opening bracket.
David
next prev parent reply other threads:[~2018-03-07 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 17:55 [PATCH 1/3] certs: define a trusted platform keyring Nayna Jain
2018-02-28 17:55 ` [PATCH 2/3] keys: export find_keyring_by_name() Nayna Jain
2018-02-28 17:55 ` [PATCH 3/3] ima: support platform keyring for kernel appraisal Nayna Jain
2018-03-07 16:03 ` David Howells [this message]
2018-03-07 17:47 ` [PATCH 1/3] certs: define a trusted platform keyring Nayna Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31489.1520438598@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).