From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE09C2D0DB for ; Fri, 24 Jan 2020 20:24:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BBE02072C for ; Fri, 24 Jan 2020 20:24:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392444AbgAXUX7 (ORCPT ); Fri, 24 Jan 2020 15:23:59 -0500 Received: from smtprelay0102.hostedemail.com ([216.40.44.102]:38050 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388215AbgAXUX6 (ORCPT ); Fri, 24 Jan 2020 15:23:58 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id B7182182CED34; Fri, 24 Jan 2020 20:23:56 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: front94_3f46724fd7512 X-Filterd-Recvd-Size: 5158 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Fri, 24 Jan 2020 20:23:54 +0000 (UTC) Message-ID: <315149bed8f3442fabcb36ec9d8c8caffe8e11eb.camel@perches.com> Subject: Re: [PATCH] iio: ad5755: fix spelling mistake "to" -> "too" From: Joe Perches To: David Laight , "'Ardelean, Alexandru'" , "zzzzPopa, zzzzStefan Serban" , "linux-iio@vger.kernel.org" , "jic23@kernel.org" , "colin.king@canonical.com" , "Hennerich, Michael" , "lars@metafoo.de" , "knaack.h@gmx.de" , "pmeerw@pmeerw.net" Cc: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Fri, 24 Jan 2020 12:22:52 -0800 In-Reply-To: <69bbc2af79d9463681b54d0aa240f89b@AcuMS.aculab.com> References: <20200122235839.2830850-1-colin.king@canonical.com> <69bbc2af79d9463681b54d0aa240f89b@AcuMS.aculab.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-01-23 at 14:55 +0000, David Laight wrote: > From Ardelean, Alexandru > > Sent: 23 January 2020 07:03 > > > > On Wed, 2020-01-22 at 23:58 +0000, Colin King wrote: > > > [External] > > > > > > From: Colin Ian King > > > > > > There is a spelling mistake in a dev_err message. Fix it. > > > > > > Signed-off-by: Colin Ian King > > > --- > > > drivers/iio/dac/ad5755.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c > > > index b9175fb4c8ab..dad0b26228a2 100644 > > > --- a/drivers/iio/dac/ad5755.c > > > +++ b/drivers/iio/dac/ad5755.c > > > @@ -655,7 +655,7 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct > > > device *dev) > > > for_each_child_of_node(np, pp) { > > > if (devnr >= AD5755_NUM_CHANNELS) { > > > dev_err(dev, > > > - "There is to many channels defined in DT\n"); > > > + "There is too many channels defined in DT\n"); > > > > If going for the spelling stuff, maybe also change "is" to "are": > > 'There are too many channels defined in DT\n' > > Probably better still: "The DT defines too many channels\n" bikeshedding: How about fixing: o missing newlines o odd indentation o unnecessary braces o message grammar at the same time? --- drivers/iio/dac/ad5755.c | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c index b9175f..f6e4cf92 100644 --- a/drivers/iio/dac/ad5755.c +++ b/drivers/iio/dac/ad5755.c @@ -631,10 +631,9 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct device *dev) } } - if (i == ARRAY_SIZE(ad5755_dcdc_freq_table)) { + if (i == ARRAY_SIZE(ad5755_dcdc_freq_table)) dev_err(dev, - "adi,dc-dc-freq out of range selecting 410kHz"); - } + "adi,dc-dc-freq out of range selecting 410kHz\n"); } pdata->dc_dc_maxv = AD5755_DC_DC_MAXV_23V; @@ -645,17 +644,15 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct device *dev) break; } } - if (i == ARRAY_SIZE(ad5755_dcdc_maxv_table)) { - dev_err(dev, - "adi,dc-dc-maxv out of range selecting 23V"); - } + if (i == ARRAY_SIZE(ad5755_dcdc_maxv_table)) + dev_err(dev, + "adi,dc-dc-maxv out of range selecting 23V\n"); } devnr = 0; for_each_child_of_node(np, pp) { if (devnr >= AD5755_NUM_CHANNELS) { - dev_err(dev, - "There is to many channels defined in DT\n"); + dev_err(dev, "Too many channels defined in DT\n"); goto error_out; } @@ -681,11 +678,10 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct device *dev) break; } } - if (i == ARRAY_SIZE(ad5755_slew_rate_table)) { + if (i == ARRAY_SIZE(ad5755_slew_rate_table)) dev_err(dev, - "channel %d slew rate out of range selecting 64kHz", + "channel %d slew rate out of range selecting 64kHz\n", devnr); - } pdata->dac[devnr].slew.step_size = AD5755_SLEW_STEP_SIZE_1; for (i = 0; i < ARRAY_SIZE(ad5755_slew_step_table); i++) { @@ -695,11 +691,10 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct device *dev) break; } } - if (i == ARRAY_SIZE(ad5755_slew_step_table)) { + if (i == ARRAY_SIZE(ad5755_slew_step_table)) dev_err(dev, - "channel %d slew step size out of range selecting 1 LSB", + "channel %d slew step size out of range selecting 1 LSB\n", devnr); - } } else { pdata->dac[devnr].slew.enable = false; pdata->dac[devnr].slew.rate = AD5755_SLEW_RATE_64k;