From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Al Stone <ahs3@redhat.com>
Cc: al.stone@linaro.org, lenb@kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, robert.moore@intel.com, tony.luck@intel.com,
fenghua.yu@intel.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
devel@acpica.org, linux-arm-kernel@lists.infradead.org,
linaro-acpi@lists.linaro.org, linaro-kernel@lists.linaro.org,
patches@linaro.org
Subject: Re: [PATCH v2 1/5] ACPI: move acpi_os_handler() so it can be made arch-dependent later
Date: Thu, 05 Feb 2015 00:21:34 +0100 [thread overview]
Message-ID: <31637855.MY7BmyVont@vostro.rjw.lan> (raw)
In-Reply-To: <54D2A0E2.8050504@redhat.com>
On Wednesday, February 04, 2015 03:44:50 PM Al Stone wrote:
> On 02/04/2015 06:50 AM, Rafael J. Wysocki wrote:
> > On Tuesday, February 03, 2015 05:21:40 PM al.stone@linaro.org wrote:
> >> From: Al Stone <al.stone@linaro.org>
> >>
> >> In order to deprecate the use of _OSI for arm64 or other new architectures,
> >> we need to make the default handler something we can change for various
> >> platforms. This patch moves the definition of acpi_osi_handler() -- the
> >> function used by ACPICA as a callback for evaluating _OSI -- into a separate
> >> file. Subsequent patches will change which files get built so that we can
> >> then build the version of _OSI we need for a particular architecture.
> >>
> >> There is no functional change.
> >>
> >> Signed-off-by: Al Stone <al.stone@linaro.org>
> >> ---
> >> drivers/acpi/Makefile | 2 +-
> >> drivers/acpi/osi.c | 100 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >> drivers/acpi/osl.c | 24 ------------
> >> include/linux/acpi.h | 1 +
> >> 4 files changed, 102 insertions(+), 25 deletions(-)
> >> create mode 100644 drivers/acpi/osi.c
> >>
> >> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> >> index c346011..df348b3 100644
> >> --- a/drivers/acpi/Makefile
> >> +++ b/drivers/acpi/Makefile
> >> @@ -18,7 +18,7 @@ obj-y += acpi.o \
> >> acpica/
> >>
> >> # All the builtin files are in the "acpi." module_param namespace.
> >> -acpi-y += osl.o utils.o reboot.o
> >> +acpi-y += osl.o utils.o reboot.o osi.o
> >> acpi-y += nvs.o
> >>
> >> # Power management related files
> >> diff --git a/drivers/acpi/osi.c b/drivers/acpi/osi.c
> >> new file mode 100644
> >> index 0000000..fff2b0c
> >> --- /dev/null
> >> +++ b/drivers/acpi/osi.c
> >> @@ -0,0 +1,100 @@
> >> +/*
> >> + * osi.c - _OSI implementation (moved from drivers/acpi/osl.c)
> >> + *
> >> + * Copyright (C) 2000 Andrew Henroid
> >> + * Copyright (C) 2001, 2002 Andy Grover <andrew.grover@intel.com>
> >> + * Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
> >> + * Copyright (c) 2008 Intel Corporation
> >> + * Author: Matthew Wilcox <willy@linux.intel.com>
> >> + *
> >> + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> + *
> >> + * This program is free software; you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License as published by
> >> + * the Free Software Foundation; either version 2 of the License, or
> >> + * (at your option) any later version.
> >> + *
> >> + * This program is distributed in the hope that it will be useful,
> >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> >> + * GNU General Public License for more details.
> >
> > Nit: The street address of the FSF is not really useful here. What if they move? :-)
>
> This was one of the things checkpatch complained about, understandably :). It's
> a direct cut'n'paste from osl.c.
>
> I can clean these up in the new file; would it help to clean up osl.c (at least
> from checkpatch's point of view), as long as I'm at it?
Yeah, won't hurt. :-)
In a separate patch please, though.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-02-04 22:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 0:21 [PATCH v2 0/5] Start deprecating _OSI on new architectures al.stone
2015-02-04 0:21 ` [PATCH v2 1/5] ACPI: move acpi_os_handler() so it can be made arch-dependent later al.stone
2015-02-04 13:50 ` Rafael J. Wysocki
2015-02-04 22:44 ` Al Stone
2015-02-04 23:21 ` Rafael J. Wysocki [this message]
2015-02-04 23:49 ` Al Stone
2015-02-04 0:21 ` [PATCH v2 2/5] ACPI: move _OSI support functions to allow arch-dependent implementation al.stone
2015-02-04 0:21 ` [PATCH v2 3/5] ACPI: add arch-specific compilation for _OSI and the blacklist al.stone
2015-02-04 14:00 ` Rafael J. Wysocki
2015-02-04 14:03 ` Rafael J. Wysocki
2015-02-04 22:46 ` Al Stone
2015-02-04 0:21 ` [PATCH v2 4/5] ACPI: arm64: use the arch-specific ACPI _OSI method and ACPI blacklist al.stone
2015-02-04 0:21 ` [PATCH v2 5/5] ACPI: arm64: use "Linux" as ACPI_OS_NAME for _OS on arm64 al.stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31637855.MY7BmyVont@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=ahs3@redhat.com \
--cc=al.stone@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devel@acpica.org \
--cc=fenghua.yu@intel.com \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=robert.moore@intel.com \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).