linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkh@osg.samsung.com>
To: shuah@kernel.org, dvhart@infradead.org, tbird20d@gmail.com
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
	tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH 1/5] selftests: kselftest framework: add handling for TAP header level
Date: Fri, 23 Feb 2018 15:11:36 -0700	[thread overview]
Message-ID: <3176a8f2e1aaf19632cece19a7945a12e5ebc35f.1519423340.git.shuahkh@osg.samsung.com> (raw)
In-Reply-To: <cover.1519423340.git.shuahkh@osg.samsung.com>
In-Reply-To: <cover.1519423340.git.shuahkh@osg.samsung.com>

Introduce environment variable KSFT_TAP_LEVEL to avoid printing
nested TAP headers for each test. lib.mk run_tests target prints
TAP header before invoking the test program or test script. Tests
need a way to suppress TAP headers if it is already printed out.

This new environment variable adds a way for ksft_print_header()
print TAP header only when KSFT_TAP_LEVEL isn't set.

lib.mk run_tests and test program should print TAP header and set
KSFT_TAP_LEVEL to avoid a second TAP header to be printed.

selftests Makefile should export KSFT_TAP_LEVEL and add TAP Header
echo to the run_kselftest.sh script from emit_tests target handling.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 tools/testing/selftests/kselftest.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
index 1a52b03962a3..1b9d8ecdebce 100644
--- a/tools/testing/selftests/kselftest.h
+++ b/tools/testing/selftests/kselftest.h
@@ -57,7 +57,8 @@ static inline int ksft_get_error_cnt(void) { return ksft_cnt.ksft_error; }
 
 static inline void ksft_print_header(void)
 {
-	printf("TAP version 13\n");
+	if (!(getenv("KSFT_TAP_LEVEL")))
+		printf("TAP version 13\n");
 }
 
 static inline void ksft_print_cnts(void)
-- 
2.14.1


  reply	other threads:[~2018-02-23 22:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23 22:11 [PATCH 0/5] Handling for TAP header level Shuah Khan
2018-02-23 22:11 ` Shuah Khan [this message]
2018-02-23 22:11 ` [PATCH 2/5] selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers Shuah Khan
2018-02-23 22:11 ` [PATCH 3/5] selftests: Makefile " Shuah Khan
2018-02-23 22:11 ` [PATCH 4/5] selftests: size call ksft_print_header() to print TAP header Shuah Khan
2018-02-23 22:11 ` [PATCH 5/5] selftests: futex Makefile add top level TAP header echo to RUN_TESTS Shuah Khan
2018-02-24 21:42   ` Darren Hart
2018-02-27 17:25     ` Shuah Khan
2018-03-06  0:17       ` Darren Hart
2018-02-24  8:39 ` [PATCH 0/5] Handling for TAP header level Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3176a8f2e1aaf19632cece19a7945a12e5ebc35f.1519423340.git.shuahkh@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=tbird20d@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).