From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755723AbcH1RNT (ORCPT ); Sun, 28 Aug 2016 13:13:19 -0400 Received: from mout.web.de ([217.72.192.78]:58119 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755375AbcH1RNQ (ORCPT ); Sun, 28 Aug 2016 13:13:16 -0400 Subject: [PATCH 1/6] KVM: PPC: e500: Use kmalloc_array() in kvm_vcpu_ioctl_config_tlb() To: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Alexander Graf , Benjamin Herrenschmidt , Michael Ellerman , Paolo Bonzini , Paul Mackerras , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <317e0112-55cc-cc91-100f-bc5e301dbe76@users.sourceforge.net> Date: Sun, 28 Aug 2016 19:12:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:nnRYpQNy/zUgfXokf10zmHplNTFlC2daV6+9mUFmArQwYHhkAR9 O2zMTrnWOAO9+nsuQhFVBshF9HGLLdjNwelst6INnLXRJnVYKTjIxGXEgJfwV2cuL4z7Y+6 7n0yF4A2TeH8kmZQtyoDY6U17UUxpLIBV5v+En3/CwaOX1T0iXDFCYg8J02ZeAnGIZrI9Fv 1sKhSi1EH0Xqb0bMT9NJQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:xp2m0UFFoOY=:aHcZp1NwFO4pShEfYcWRzV DkXe5/0Tqtlc0D6vBsnRQhDyrauEyi5Y/isD43v10HW9b2PolzGHuPAkrsyeV2d/eTd82w+0E ybuq//0vrNn5G38h2DmtdUqM3rCu55Dw8iowxM7Rh8XzHB32ZCo3NNCh3GSKhUJ4awLduayBQ J+Edc5Tc6Af8NM8uiPlgbEj5v/KdV1wUV2M3ubrzXZGp1gSpQWiy4Olj0szSShTwU4RP64JLu MAd7oJaUzFfXVVFbNxGx33AlpO9KOlqwr4g13K8B+U0kbbNmf4a5tRW8sBGEg808AMXbqnNnS ktU8M8+WTYBnikythJeBaji3kGolLeC0e8YX+FFW6HWXHds3IfRJZeS1krWYwM8xcPAFLWeae di1+a7uNvZZn2IfYm5ZmIDTKhthyTRa4yWXw7piJeKictIxgmAOSCLPE5wC9Hu4thv6PfmdP/ ijD9Dc+kW8yTauduG9srMX4/NsHOg5TTXtl6lPaUqjU48GGPoJ7ThyQ1KiRIXT7xt6W+wMiO8 Wyw7vf+0BYJFCCkCAJI9TUo58B6DQtLLY2yy3l9kL/JsShh0pJE0S5ozjMs5OnGGAVzeeNs2R nRP8aHPmVMflGme0nAPzlVPUbUI3WhCQyc6M4kennthoHSPJjWV8tQYuCzPBArk3RLQO0IKfZ nEZ4BUeIxyjSZDhl48YqneDLId1FrsTCXqQFsEbXR+w3ve2m7u0fjpXPhlkzFtaJKU+JwbfNt sA12t9XHfxjDSD6B6Md5YEFob7GVaESOTxjdpeY4qYNB1bQVwNS8j8hitDnK5T8Z7qODwNbCH PoO4CGE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 28 Aug 2016 16:30:07 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/powerpc/kvm/e500_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/e500_mmu.c b/arch/powerpc/kvm/e500_mmu.c index 29911a0..26f3737 100644 --- a/arch/powerpc/kvm/e500_mmu.c +++ b/arch/powerpc/kvm/e500_mmu.c @@ -779,7 +779,7 @@ int kvm_vcpu_ioctl_config_tlb(struct kvm_vcpu *vcpu, num_pages = DIV_ROUND_UP(cfg->array + array_len - 1, PAGE_SIZE) - cfg->array / PAGE_SIZE; - pages = kmalloc(sizeof(struct page *) * num_pages, GFP_KERNEL); + pages = kmalloc_array(num_pages, sizeof(*pages), GFP_KERNEL); if (!pages) return -ENOMEM; -- 2.9.3