From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C771ACA9ECF for ; Mon, 4 Nov 2019 09:41:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A803921744 for ; Mon, 4 Nov 2019 09:41:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728020AbfKDJle (ORCPT ); Mon, 4 Nov 2019 04:41:34 -0500 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:53207 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727553AbfKDJld (ORCPT ); Mon, 4 Nov 2019 04:41:33 -0500 Received: from [192.168.2.10] ([46.9.232.237]) by smtp-cloud9.xs4all.net with ESMTPA id RYrQia6J69P9bRYrViVSex; Mon, 04 Nov 2019 10:41:30 +0100 Subject: Re: [PATCH 4/4] v4l2-ctl: Support setting V4L2_CTRL_TYPE_AREA controls To: Ricardo Ribalda Delgado , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191101112509.29723-1-ribalda@kernel.org> <20191101112509.29723-4-ribalda@kernel.org> From: Hans Verkuil Message-ID: <31815641-550c-88ab-c037-2e743cea59b3@xs4all.nl> Date: Mon, 4 Nov 2019 10:41:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191101112509.29723-4-ribalda@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfLHx2lXm3zADOqbQZkkkD01AMPJ03Xm5aaOAeDjEfL6lIZPvSL2vMYiRWEQIlH0m0UG0JSdDG5JwQUhH16IMnAoVfGabqymDiL56uwuQwb4jjwkS+rpU XBoJO/1JWPZPxw8NC9bt1lHIgSqvND4zeJkh9OD1rmX9h3AGnkUgf2+2XDnsHWqKo+PyJPjrnm8AQHOgCQ7yiePxJu6OJWWgWysz8G9O655xNd+e9ZYqOn4+ jkJ/J/T7M08tkCtLKUcsFA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/1/19 12:25 PM, Ricardo Ribalda Delgado wrote: > $ v4l2-ctl -d /dev/video1 -c area=123123x233 > > Signed-off-by: Ricardo Ribalda Delgado > --- > utils/v4l2-ctl/v4l2-ctl-common.cpp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp > index 95339561..676b05e0 100644 > --- a/utils/v4l2-ctl/v4l2-ctl-common.cpp > +++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp > @@ -973,6 +973,10 @@ void common_set(cv4l_fd &_fd) > strncpy(ctrl.string, iter->second.c_str(), qc.maximum); > ctrl.string[qc.maximum] = 0; > break; > + case V4L2_CTRL_TYPE_AREA: > + sscanf(iter->second.c_str(), "%dx%d", Use %ux%u since these are unsigned values. Regards, Hans > + &ctrl.p_area->width, &ctrl.p_area->height); > + break; > default: > fprintf(stderr, "%s: unsupported payload type\n", > qc.name); >