From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964906AbdDTFpD (ORCPT ); Thu, 20 Apr 2017 01:45:03 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:32918 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941051AbdDTFpA (ORCPT ); Thu, 20 Apr 2017 01:45:00 -0400 Subject: Re: [PATCH v3 2/5] ARM: dts: rockchip: add ARM Mali GPU node for rk3288 To: Heiko Stuebner References: <5403013.fQWx48MQOq@phil> Cc: Rob Herring , Mark Rutland , Neil Armstrong , Sjoerd Simons , Enric Balletbo i Serra , John Reitan , Wookey , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Guillaume Tucker Message-ID: <319a2a72-ca25-08d7-68dc-7eae74f1a622@collabora.com> Date: Thu, 20 Apr 2017 06:44:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <5403013.fQWx48MQOq@phil> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 19/04/17 09:59, Heiko Stuebner wrote: > Am Mittwoch, 19. April 2017, 09:06:18 CEST schrieb Guillaume Tucker: >> Add Mali GPU device tree node for the rk3288 SoC, with devfreq >> opp table. >> >> Tested-by: Enric Balletbo i Serra >> Signed-off-by: Guillaume Tucker >> --- >> arch/arm/boot/dts/rk3288.dtsi | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi >> index df8a0dbe9d91..187eed528f83 100644 >> --- a/arch/arm/boot/dts/rk3288.dtsi >> +++ b/arch/arm/boot/dts/rk3288.dtsi >> @@ -43,6 +43,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -227,6 +228,27 @@ >> ports = <&vopl_out>, <&vopb_out>; >> }; >> >> + gpu: mali@ffa30000 { > > please sort nodes by address. ffa30000 should be placed below hdmi@ff980000 > and above qos@ffaa0000 . Sure, will fix that in v4. >> + compatible = "arm,mali-t760", "arm,mali-midgard"; > > As indicated before I don't trust that a generic binding will work for > everything, so I would feel safer if we had a "rockchip,rk3288-mali" in > front for future purposes, making it a > > compatible = "rockchip,rk3288-mali", "arm,mali-t760", "arm,mali-midgard"; OK, sorry I overlooked this part. I'll add it in v4 with a vendor compatible string in the binding documentation. >> + reg = <0xffa30000 0x10000>; >> + interrupts = , >> + , >> + ; >> + interrupt-names = "job", "mmu", "gpu"; >> + clocks = <&cru ACLK_GPU>; >> + operating-points = < >> + /* KHz uV */ >> + 100000 950000 >> + 200000 950000 >> + 300000 1000000 >> + 400000 1100000 >> + 500000 1200000 >> + 600000 1250000 >> + >; > > Wasn't there a wish for opp-v2 in a previous version? Well it wasn't entirely clear to me in Rob's email whether it was necessary to use opp-v2 now or rather if it would be a potential option whenever opp-v2 was needed. If operating-points (v1) are being deprecated then I can change that in my next patch v4. Using operating-points-v2 with the Mali driver works as far as I can tell on rk3288 so that's not an issue. Thanks, Guillaume