From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Andrei Vagin <avagin@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Dmitry Safonov <dima@arista.com>
Subject: Re: [PATCH v2 5/6] arm64/vdso: Restrict splitting VVAR VMA
Date: Thu, 9 Apr 2020 13:05:17 +0100 [thread overview]
Message-ID: <31a0e784-7d38-b9aa-d84c-8deb6436b647@arm.com> (raw)
In-Reply-To: <20200225073731.465270-6-avagin@gmail.com>
On 2/25/20 7:37 AM, Andrei Vagin wrote:
> Forbid splitting VVAR VMA resulting in a stricter ABI and reducing the
> amount of corner-cases to consider while working further on VDSO time
> namespace support.
>
> As the offset from timens to VVAR page is computed compile-time, the pages
> in VVAR should stay together and not being partically mremap()'ed.
>
> Signed-off-by: Andrei Vagin <avagin@gmail.com>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> arch/arm64/kernel/vdso.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
> index fb32c6f76078..c003f7ee383a 100644
> --- a/arch/arm64/kernel/vdso.c
> +++ b/arch/arm64/kernel/vdso.c
> @@ -235,6 +235,17 @@ static vm_fault_t vvar_fault(const struct vm_special_mapping *sm,
> return vmf_insert_pfn(vma, vmf->address, pfn);
> }
>
> +static int vvar_mremap(const struct vm_special_mapping *sm,
> + struct vm_area_struct *new_vma)
> +{
> + unsigned long new_size = new_vma->vm_end - new_vma->vm_start;
> +
> + if (new_size != VVAR_NR_PAGES * PAGE_SIZE)
> + return -EINVAL;
> +
> + return 0;
> +}
> +
> static int __setup_additional_pages(enum arch_vdso_type arch_index,
> struct mm_struct *mm,
> struct linux_binprm *bprm,
> @@ -315,6 +326,7 @@ static struct vm_special_mapping aarch32_vdso_spec[C_PAGES] = {
> {
> .name = "[vvar]",
> .fault = vvar_fault,
> + .mremap = vvar_mremap,
> },
> {
> .name = "[vdso]",
> @@ -497,6 +509,7 @@ static struct vm_special_mapping vdso_spec[A_PAGES] __ro_after_init = {
> {
> .name = "[vvar]",
> .fault = vvar_fault,
> + .mremap = vvar_mremap,
> },
> {
> .name = "[vdso]",
>
--
Regards,
Vincenzo
next prev parent reply other threads:[~2020-04-09 12:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 7:37 [PATCH v2 0/6] arm64: add the time namespace support Andrei Vagin
2020-02-25 7:37 ` [PATCH v2 1/6] arm64/vdso: use the fault callback to map vvar pages Andrei Vagin
2020-04-09 12:01 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 2/6] arm64/vdso: Zap vvar pages when switching to a time namespace Andrei Vagin
2020-04-09 12:01 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 3/6] arm64/vdso: Add time napespace page Andrei Vagin
2020-04-09 12:03 ` Vincenzo Frascino
2020-04-14 17:20 ` Mark Rutland
2020-04-15 2:34 ` Andrei Vagin
2020-04-15 10:05 ` Mark Rutland
2020-04-15 10:16 ` Vincenzo Frascino
2020-04-15 12:27 ` Mark Rutland
2020-02-25 7:37 ` [PATCH v2 4/6] arm64/vdso: Handle faults on timens page Andrei Vagin
2020-04-09 12:04 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 5/6] arm64/vdso: Restrict splitting VVAR VMA Andrei Vagin
2020-04-09 12:05 ` Vincenzo Frascino [this message]
2020-02-25 7:37 ` [PATCH v2 6/6] arm64: enable time namespace support Andrei Vagin
2020-04-09 12:06 ` Vincenzo Frascino
2020-04-01 6:50 ` [PATCH v2 0/6] arm64: add the " Andrei Vagin
2020-04-01 9:02 ` Vincenzo Frascino
2020-04-09 13:24 ` Vincenzo Frascino
2020-04-11 7:33 ` Andrei Vagin
2020-04-14 9:02 ` Vincenzo Frascino
2020-04-15 16:14 ` Andrei Vagin
2020-04-15 16:35 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31a0e784-7d38-b9aa-d84c-8deb6436b647@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=avagin@gmail.com \
--cc=dima@arista.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).