linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>
Cc: Greg Thelen <gthelen@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, page_alloc: set num_movable in move_freepages()
Date: Tue, 16 Oct 2018 14:24:01 +0200	[thread overview]
Message-ID: <31b62d5d-11f6-6a68-fa04-889c98b66d9b@suse.cz> (raw)
In-Reply-To: <20181005142143.30032b7a4fb9dc2b587a8c21@linux-foundation.org>

On 10/5/18 11:21 PM, Andrew Morton wrote:
> On Fri, 5 Oct 2018 13:56:39 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:
> 
>> If move_freepages() returns 0 because zone_spans_pfn(), *num_movable can
> 
>      move_free_pages_block()?           !zone_spans_pfn()?

Also the subject would be more accurate if it said "initialize
num_movable in move_freepages_block()" ?

Otherwise,
Acked-by: Vlastimil Babka <vbabka@suse.cz>

>> hold the value from the stack because it does not get initialized in
>> move_freepages().
>>
>> Move the initialization to move_freepages_block() to guarantee the value
>> actually makes sense.
>>
>> This currently doesn't affect its only caller where num_movable != NULL,
>> so no bug fix, but just more robust.
>>
>> ...
> 


      parent reply	other threads:[~2018-10-16 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 20:56 [patch] mm, page_alloc: set num_movable in move_freepages() David Rientjes
2018-10-05 21:21 ` Andrew Morton
2018-10-07 22:35   ` David Rientjes
2018-10-16 12:24   ` Vlastimil Babka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31b62d5d-11f6-6a68-fa04-889c98b66d9b@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=gthelen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).