From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org by pdx-caf-mail.web.codeaurora.org (Dovecot) with LMTP id yRE5Gp2gHltiOQAAmS7hNA ; Mon, 11 Jun 2018 16:19:05 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4228C607A4; Mon, 11 Jun 2018 16:19:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by smtp.codeaurora.org (Postfix) with ESMTP id B5AA2601C3; Mon, 11 Jun 2018 16:19:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B5AA2601C3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933349AbeFKQTC (ORCPT + 20 others); Mon, 11 Jun 2018 12:19:02 -0400 Received: from foss.arm.com ([217.140.101.70]:53570 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932298AbeFKQTB (ORCPT ); Mon, 11 Jun 2018 12:19:01 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D5F0A1435; Mon, 11 Jun 2018 09:19:00 -0700 (PDT) Received: from [10.1.206.73] (en101.cambridge.arm.com [10.1.206.73]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E93893F59D; Mon, 11 Jun 2018 09:18:59 -0700 (PDT) Subject: Re: [PATCH v2 5/5] arm64: perf: Add support for chaining event counters To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will.deacon@arm.com, robin.murphy@arm.com References: <1527591356-10934-1-git-send-email-suzuki.poulose@arm.com> <1527591356-10934-6-git-send-email-suzuki.poulose@arm.com> <20180606180119.4ofhges6codarbmk@lakrids.cambridge.arm.com> <4a5b5e7f-fc0b-84e3-fc65-b9f860029207@arm.com> <847dfe5c-665c-6398-f87f-3ca56e73f5aa@arm.com> <20180611142431.4svc26y27scgzfcg@lakrids.cambridge.arm.com> From: Suzuki K Poulose Message-ID: <31b8ddfa-d1e3-030f-e929-edd727deb2f2@arm.com> Date: Mon, 11 Jun 2018 17:18:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180611142431.4svc26y27scgzfcg@lakrids.cambridge.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/18 15:24, Mark Rutland wrote: > On Mon, Jun 11, 2018 at 02:54:16PM +0100, Suzuki K Poulose wrote: >> On 08/06/18 15:46, Suzuki K Poulose wrote: >>> On 06/06/2018 07:01 PM, Mark Rutland wrote: >>>> On Tue, May 29, 2018 at 11:55:56AM +0100, Suzuki K Poulose wrote: >> >>>>> -        value |= 0xffffffff00000000ULL; >>>>> +        if (!armv8pmu_event_is_64bit(event)) >>>>> +            value |= 0xffffffff00000000ULL; >>>>>           write_sysreg(value, pmccntr_el0); >>>>> -    } else if (armv8pmu_select_counter(idx) == idx) >>>>> -        write_sysreg(value, pmxevcntr_el0); >>>>> +    } else >>>>> +        armv8pmu_write_hw_counter(event, value); >>>>>   } >>>> >>>>> +static inline void armv8pmu_write_event_type(struct perf_event *event) >>>>> +{ >>>>> +    struct hw_perf_event *hwc = &event->hw; >>>>> +    int idx = hwc->idx; >>>>> + >>>>> +    /* >>>>> +     * For chained events, write the the low counter event type >>>>> +     * followed by the high counter. The high counter is programmed >>>>> +     * with CHAIN event code with filters set to count at all ELs. >>>>> +     */ >>>>> +    if (armv8pmu_event_is_chained(event)) { >>>>> +        u32 chain_evt = ARMV8_PMUV3_PERFCTR_CHAIN | >>>>> +                ARMV8_PMU_INCLUDE_EL2; >>>>> + >>>>> +        armv8pmu_write_evtype(idx - 1, hwc->config_base); >>>>> +        isb(); >>>>> +        armv8pmu_write_evtype(idx, chain_evt); >>>> >>>> The ISB isn't necessary here, AFAICT. We only do this while the PMU is >>>> disabled; no? >>> >>> You're right. I was just following the ARM ARM. >> >> Taking another look, it is not clear about the semantics of "pmu->enable()" >> and pmu->disable() callbacks. > > I was talking about pmu::{pmu_disable,pmu_enable}(), so I'm not sure I > follow how arm_pmu::{enable,disable}() are relevant here.> > The arm_pmu::{enable,disable}() callbacks enable or disable individual > counters. For example, leaving unused counters disabled may save power, > even if the PMU as a whole is enabled. Ah, I mistook cpu_pmu->enable/disable for the core pmu ops. My bad. Sorry about the noise. Suzuki