From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC0DC10F13 for ; Wed, 27 Jan 2021 01:51:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AB99206A4 for ; Wed, 27 Jan 2021 01:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405463AbhA0BrS (ORCPT ); Tue, 26 Jan 2021 20:47:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395045AbhAZTEZ (ORCPT ); Tue, 26 Jan 2021 14:04:25 -0500 X-Greylist: delayed 460 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 26 Jan 2021 11:03:45 PST Received: from iam.tj (unknown [IPv6:2a01:7e00:e000:151::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E56FC061573 for ; Tue, 26 Jan 2021 11:03:45 -0800 (PST) Received: from [IPv6:2a02:8011:2007:0:37a2:855e:7ada:e97f] (unknown [IPv6:2a02:8011:2007:0:37a2:855e:7ada:e97f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by iam.tj (Postfix) with ESMTPSA id 93A01340F6; Tue, 26 Jan 2021 18:56:00 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elloe.vision; s=2019; t=1611687361; bh=pW5BRli1GLGipBIINvB0TPU8uc9pLCA7uO+KzYIjKp0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=QLqnp4U75FOJmxWaBj47zhyMtwv3z5qUoxEt5iy32Ze+uuN88tnXz0r1iCIZ7WIty 6mRj29gYHxQjrtcJPbgRYD1DPb0GLMryd4SMtro3kaMNV9DqQri6LRSK8QNrmONmZi LJlRxWa0Up0K/csa1kOPlL7iPM6Lxka35SVEP07pdF7C+cEDqaaSNmEFchORoB4/Yg ACjc2fYPdB2azFATIu/EKw7W9Cu+xsF7wgxyqxA2H8vRQeIco1+oOKWrFg9FFOeX3c WMHTLnP7ttgzlspCye1Gw/Q9QPvWJ/pBVwhKdKu72Y4S5bZ+JCyk9EFO8vGVlUZ5Wv 13uxMcGjh+1GA== Subject: Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls To: James Bottomley , =?UTF-8?Q?=c5=81ukasz_Majczak?= , Guenter Roeck , Dirk Gouders Cc: Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Radoslaw Biernacki , Marcin Wojtas , Alex Levin References: <20210123014247.989368-1-lma@semihalf.com> <20210125171846.GA31929@roeck-us.net> From: "Tj (Elloe Linux)" Organization: Elloe CIC Message-ID: <31c50c4f-487f-1977-2962-4a138b0d0ecc@elloe.vision> Date: Tue, 26 Jan 2021 18:55:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/01/2021 16:46, James Bottomley wrote: > On Tue, 2021-01-26 at 16:46 +0100, Łukasz Majczak wrote: >> Hi Jarkko, Guenter >> >> Yes, here are the logs when failure occurs - >> https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 >> Look for a phrase "TPM returned invalid status" > > We've had other reports of this: > > https://lore.kernel.org/linux-integrity/ghsgagsnag.fsf@gouders.net/ > https://lore.kernel.org/linux-integrity/374e918c-f167-9308-2bea-ae6bc6a3d2e3@elloe.vision/ > > The problem is some TIS TPMs don't begin in the correct locality so we > have to set it. When I proposed the check, I also proposed a fix for > this problem: > > https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/ > This patch solves the error messages on top of -rc5 > But it's part of a series that never went upstream. Part of the reason > was Jarkko proposed the get/put patch to fix this instead, but that > never went upstream either. We need to decide an approach and apply > one or other fixes. > > James > >