From: Jarkko Sakkinen <jarkko@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
James Bottomley <jejb@linux.ibm.com>,
Mimi Zohar <zohar@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 2/2] tpm: use SM3 instead of SM3_256
Date: Fri, 15 Oct 2021 18:19:57 +0300 [thread overview]
Message-ID: <31d49f7785dd82fd2f0c1078c9a94153e3c389ac.camel@kernel.org> (raw)
In-Reply-To: <5db32f21-1df7-c92e-42a1-a2a85b29dfbf@linux.alibaba.com>
On Thu, 2021-10-14 at 17:46 +0800, Tianjia Zhang wrote:
> Hi Jarkko,
>
> On 10/12/21 11:21 PM, Jarkko Sakkinen wrote:
> > On Sat, 2021-10-09 at 21:08 +0800, Tianjia Zhang wrote:
> > > According to https://tools.ietf.org/id/draft-oscca-cfrg-sm3-01.html,
> > > SM3 always produces a 256-bit hash value and there are no plans for
> > > other length development, so there is no ambiguity in the name of sm3.
> > >
> > > Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> >
> > This is not enough to make any changes because the commit message
> > does not describe what goes wrong if we keep it as it was.
> >
> > /Jarkko
> >
>
> This did not cause an error, just to use a more standard algorithm name.
> If it is possible to use the SM3 name instead of SM3_256 if it can be
> specified from the source, it is of course better. I have contacted the
> trustedcomputinggroup and have not yet received a reply.
>
> Best regards,
> Tianjia
Why don't you then create a patch set that fully removes SM3_256, if it
is incorrect?
This looks a bit half-baked patch set.
/Jarkko
next prev parent reply other threads:[~2021-10-15 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 13:08 [PATCH 0/2] tpm: use SM3 instead of SM3_256 Tianjia Zhang
2021-10-09 13:08 ` [PATCH 1/2] crypto: " Tianjia Zhang
2021-10-18 13:05 ` James Bottomley
2021-10-18 13:27 ` Jarkko Sakkinen
2021-10-18 13:32 ` James Bottomley
2021-10-18 13:41 ` Jarkko Sakkinen
2021-10-19 9:39 ` Tianjia Zhang
2021-10-19 9:35 ` Tianjia Zhang
2021-10-09 13:08 ` [PATCH 2/2] tpm: " Tianjia Zhang
2021-10-12 15:21 ` Jarkko Sakkinen
2021-10-14 9:46 ` Tianjia Zhang
2021-10-15 15:19 ` Jarkko Sakkinen [this message]
2021-10-18 2:37 ` Tianjia Zhang
2021-10-18 12:48 ` Jarkko Sakkinen
2021-10-09 13:29 ` [PATCH 0/2] " James Bottomley
2021-10-11 7:02 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31d49f7785dd82fd2f0c1078c9a94153e3c389ac.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=serge@hallyn.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).