From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13658C4338F for ; Sat, 21 Aug 2021 10:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9C2B60EFE for ; Sat, 21 Aug 2021 10:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233929AbhHUKge (ORCPT ); Sat, 21 Aug 2021 06:36:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbhHUKgd (ORCPT ); Sat, 21 Aug 2021 06:36:33 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC12EC061575 for ; Sat, 21 Aug 2021 03:35:53 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id f10so11343605lfv.6 for ; Sat, 21 Aug 2021 03:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=p2ILHip+Un1i8xbxO/LoD+DyRHpJxEJdvl8oLcuRnHQ=; b=HlJ94LgCCzrbrmCls+aMx5C7thPSzEjKqX8GffT/ofEJSl5GYT8Bthi2/AqB4ga4JU TV6OT4QNtKUr8bi2CtXiQDr/IlDERZyzYNV9wBTC8HLLngq9dVul7jmccA4TsM9WIy/1 dfUU4u4NCdYk+8xoLC7WcGuechxu/9mgP1JuCYYg8pVCgcnQFeNi/cwcHg4afvJpW/8d kZzU1LFgXt9p97xE62Ar8qu8JsDLjMf7OZWXPpWpzDrDvdIBDg6LtzDZVXrdH4Rxu1EH hHWt4p1nO4xxKkg2ZsKIKagSiZdAzkxB4CtdJTYq+jww2NrQ0uNQnWruTDrpFjaPmVDc O3/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p2ILHip+Un1i8xbxO/LoD+DyRHpJxEJdvl8oLcuRnHQ=; b=kcom58xSweYMGjTk5rK9Nvl9zLv5Nbd4SI4zEDZ9AVgz2Ru2imM7oLscXbnr2H0FtE VC37rJdjURaPAO43zeqEP2BFLdxzFa+C3nJKnzPdLKGBFUASaPc0WvMQK1ZnEQoEaL+w hJ0NQzllso9nlvStAO7RuMPdnj6Od9LgkAVlgSFgpjxC/Uh74aWLV02awFVDR+aM+XVu PYPNnbIb/XU30E0otMwBC+kV0rpP/uGkQMI5l55GeFb0o2TMMsMI4rZ1z0RtblKiklc/ gkgeCipT94JaIsgwJOJAXDPFKfk72NdkefpbcwLb1MjL8FFEfmLIO+8T8UOeAqeRzhtX JFeg== X-Gm-Message-State: AOAM531vjhpPdCNpxy26ZgkSMPxLdBaYiEFel5q96miMtVL4HDtxRLAC So+jNMaWtgZ3jHUv6aahhNhQgdX2ONgJbQ== X-Google-Smtp-Source: ABdhPJxkz0ni7Le9UGTzLsIj5pXNyCyUv5SR8rcnU/55XuQVun9xBXgF7LKKf4DhBL5YLjcemeXWfw== X-Received: by 2002:a05:6512:3d91:: with SMTP id k17mr18218873lfv.166.1629542151956; Sat, 21 Aug 2021 03:35:51 -0700 (PDT) Received: from [192.168.1.11] ([46.235.66.127]) by smtp.gmail.com with ESMTPSA id l14sm748043lji.106.2021.08.21.03.35.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Aug 2021 03:35:51 -0700 (PDT) Subject: Re: [PATCH RFC 1/3] staging: r8188eu: add proper rtw_read* error handling To: "Fabio M. De Francesco" , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <5720270.rXTAdOU5UK@localhost.localdomain> From: Pavel Skripkin Message-ID: <31d61caa-d07d-193f-cd8e-adfbda1ff9e2@gmail.com> Date: Sat, 21 Aug 2021 13:35:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <5720270.rXTAdOU5UK@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/21/21 8:55 AM, Fabio M. De Francesco wrote: > On Friday, August 20, 2021 7:07:36 PM CEST Pavel Skripkin wrote: >> rtw_read*() functions call usb_read* inside. These functions could fail >> in some cases; for example: failed to receive control message. These >> cases should be handled to prevent uninit value bugs, since usb_read* >> functions blindly return stack variable without checking if this value >> _actualy_ initialized. >> >> To achive it, all usb_read* and rtw_read*() argument list is expanded > > Dear Pavel, > > Please, achive --> achieve. > >> with pointer to error and added error usbctrl_vendorreq() error checking. >> If transfer is successful error will be initialized to 0 otherwise to >> error returned from usb_control_msg(). >> >> To not break the build, added error checking for rtw_read*() call all >> across the driver. >> >> Signed-off-by: Pavel Skripkin >> --- >> drivers/staging/r8188eu/core/rtw_debug.c | 79 +++- >> drivers/staging/r8188eu/core/rtw_efuse.c | 83 +++- >> drivers/staging/r8188eu/core/rtw_io.c | 18 +- >> drivers/staging/r8188eu/core/rtw_mp.c | 37 +- >> drivers/staging/r8188eu/core/rtw_mp_ioctl.c | 20 +- >> drivers/staging/r8188eu/core/rtw_pwrctrl.c | 6 +- >> drivers/staging/r8188eu/core/rtw_sreset.c | 7 +- >> drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 9 +- >> drivers/staging/r8188eu/hal/hal_com.c | 22 +- >> drivers/staging/r8188eu/hal/odm_interface.c | 12 +- >> drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 37 +- >> drivers/staging/r8188eu/hal/rtl8188e_dm.c | 6 +- >> .../staging/r8188eu/hal/rtl8188e_hal_init.c | 198 +++++++-- >> drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 26 +- >> drivers/staging/r8188eu/hal/rtl8188e_sreset.c | 20 +- >> drivers/staging/r8188eu/hal/rtl8188eu_led.c | 17 +- >> drivers/staging/r8188eu/hal/usb_halinit.c | 394 ++++++++++++++---- >> drivers/staging/r8188eu/hal/usb_ops_linux.c | 16 +- >> drivers/staging/r8188eu/include/rtw_io.h | 18 +- >> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 168 +++++--- >> 20 files changed, 941 insertions(+), 252 deletions(-) > Hi, Fabio! Thank you for feedback > I agree with Philip: please, split this long patch. If I were you, I'd make > one patch for each of the three rtw_read*() and a fourth patch for usb_read*(). > Make sense. Will fix in v2. >> --- a/drivers/staging/r8188eu/core/rtw_io.c >> +++ b/drivers/staging/r8188eu/core/rtw_io.c >> @@ -34,44 +34,44 @@ jackson@realtek.com.tw >> #define rtw_cpu_to_le16(val) cpu_to_le16(val) >> #define rtw_cpu_to_le32(val) cpu_to_le32(val) > > Not related to your patch, these macros are useless and misleading. > Sorry, I don't get it. I didn't touch these macros, it's part of diffstat. >> -u8 _rtw_read8(struct adapter *adapter, u32 addr) >> +u8 _rtw_read8(struct adapter *adapter, u32 addr, int *error) >> { >> u8 r_val; >> struct io_priv *pio_priv = &adapter->iopriv; >> struct intf_hdl *pintfhdl = &pio_priv->intf; >> - u8 (*_read8)(struct intf_hdl *pintfhdl, u32 addr); >> + u8 (*_read8)(struct intf_hdl *pintfhdl, u32 addr, int *error); >> >> >> _read8 = pintfhdl->io_ops._read8; >> - r_val = _read8(pintfhdl, addr); >> + r_val = _read8(pintfhdl, addr, error); >> >> return r_val; >> } > > I really don't like passing errors through arguments. Why don't you pass > a storage location where the function save the byte read and instead use the > return for errors? I think that this would result in a cleaner design. Furthermore, > it is used everywhere in the kernel. > Yep, this will be more cleaner, but I decided to receive some feedback first about the idea. If this error handling is really necessary, I will rework this approach :) >> -u16 _rtw_read16(struct adapter *adapter, u32 addr) >> +u16 _rtw_read16(struct adapter *adapter, u32 addr, int *error) >> { >> u16 r_val; >> struct io_priv *pio_priv = &adapter->iopriv; >> struct intf_hdl *pintfhdl = &pio_priv->intf; >> - u16 (*_read16)(struct intf_hdl *pintfhdl, u32 addr); >> + u16 (*_read16)(struct intf_hdl *pintfhdl, u32 addr, int *error); >> >> _read16 = pintfhdl->io_ops._read16; >> >> - r_val = _read16(pintfhdl, addr); >> + r_val = _read16(pintfhdl, addr, error); >> >> return r_val; >> } > > Same. > >> -u32 _rtw_read32(struct adapter *adapter, u32 addr) >> +u32 _rtw_read32(struct adapter *adapter, u32 addr, int *error) >> { >> u32 r_val; >> struct io_priv *pio_priv = &adapter->iopriv; >> struct intf_hdl *pintfhdl = &pio_priv->intf; >> - u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); >> + u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr, int *error); >> >> _read32 = pintfhdl->io_ops._read32; >> >> - r_val = _read32(pintfhdl, addr); >> + r_val = _read32(pintfhdl, addr, error); >> >> return r_val; >> } > > Same. > > I'm done for now: too many lines to read all at once :) > With regards, Pavel Skripkin