From: Sibi Sankar <email@example.com> To: Brian Norris <firstname.lastname@example.org> Cc: Bjorn Andersson <email@example.com>, Ramon Fried <firstname.lastname@example.org>, email@example.com, Linux Kernel <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH] remoteproc: qcom_q6v5: don't auto boot remote processor Date: Sat, 19 Jan 2019 01:16:51 +0530 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CA+ASDXNMS1n+zBDPi4zbyDYjuEs4n-oFH2QfytvzRpnbK5-_ZQ@mail.gmail.com> On 2019-01-19 00:05, Brian Norris wrote: > On Thu, Jan 17, 2019 at 11:04 PM Sibi Sankar <email@example.com> > wrote: >> On 2018-05-29 09:50, Bjorn Andersson wrote: >> > On Thu 24 May 12:21 PDT 2018, Ramon Fried wrote: > > Whoa, bringing up a 7-month old patch? Nice. > >> >> Sometimes that rmtfs userspace module is not brought >> >> up fast enough and the modem crashes. >> >> disabling automated boot in the driver and triggering >> >> the boot from user-space sovles the problem. >> >> >> >> Signed-off-by: Ramon Fried <firstname.lastname@example.org> >> > >> > Thanks for your patch Ramon. While this nudges the behavior to make >> > things work slightly better I think we need to describe the explicit >> > dependency between the mss firmware and the existence of rmtfs. >> > >> > As our remoteprocs are essentially always-on I would prefer that they >> > start "automatically" and not through use of the sysfs interface. >> > >> > But we're at the point where this is a real problem on 410, 820 and >> > 845, >> > so we have to come up with some way to tie these pieces together. If >> > your patch suits that solution I will happily take it. >> > >> > Regards, >> > Bjorn >> >> After experimenting with in kernel solutions for >> three revisions and observing problems on graceful >> shutdown usecase, > > What exactly were the problems again? e.g., what were the deficiencies > with having the remoteproc device listen for the REMOTEFS_QMI_SVC_ID > service again? Sorry, but I sort of dropped off on reviewing that > stuff, and now I see this. I'd mildly prefer something that is > actually automatic, but if I'm missing some aspects, I'd like to hear > that. (And, I'd like to see them explained in the commit message, if > this is ever to be merged.) bringing down the modem after the RMTFS server goes down leaves the modem in limbo (It has a few pending rmtfs transactions that cannot go through) which results in sysmon graceful shutdown failing. And we have to do a modem force-stop to proceed which we want to avoid in graceful shutdown cases. This is overcome by starting rproc mss from rmtfs after REMOTEFS_QMI service is up and stopping rproc mss from rmtfs on SIGKILL/SIGINT and other program error signals before bringing down the RMTFS_QMI service i.e before exiting the rmtfs server loop. > >> switching to controlling the >> remoteproc mss through rmtfs seems to solve all >> the known issues. > > How so? It explicitly does NOT help at all if RMTFS crashes. > Because...who's going to stop the modem in that case? (It works if you > automatically respawn a new RMTFS daemon, to toggle the modem. But > that's kind of cheating, and you can do that anyway, even without this > patch.) On the contrary, your patch *would* resolve that, since the > modem would notice when the RMTFS server goes away, and it would stop > itself. yeah we would want to mimic what the kernel patch did with the exception of stopping modem before bringing down the rmtfs server (not toggle rproc state but start on rmtfs service up and stop before rmtfs server exit). So in that case we would not want the modem to auto-boot. > >> https://patchwork.kernel.org/patch/10662395/ >> >> we should probably get this merged in, now that >> we are planning to start/stop mss through >> rmtfs. > > Sorry, who's planning to stop mss through rmtfs? Did I miss something? I have a working patch which I'll soon send upstream for review, after it clears the internal reviews/processes > > Brian -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply index Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-24 19:21 Ramon Fried 2018-05-29 4:20 ` Bjorn Andersson 2018-05-29 11:31 ` Ramon Fried 2019-01-18 7:04 ` Sibi Sankar 2019-01-18 18:35 ` Brian Norris 2019-01-18 19:46 ` Sibi Sankar [this message] 2019-01-18 21:04 ` Brian Norris 2019-01-19 4:17 ` Sibi Sankar 2019-01-30 21:07 ` Bjorn Andersson
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ email@example.com firstname.lastname@example.org public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox