From: Daniel Borkmann <daniel@iogearbox.net>
To: Anders Roxell <anders.roxell@linaro.org>, ast@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] bpf: test_bpf: turn of preemption in function __run_once
Date: Mon, 25 Feb 2019 22:28:58 +0100 [thread overview]
Message-ID: <31dccc3f-3355-31b6-87c1-81d9ff35515b@iogearbox.net> (raw)
In-Reply-To: <20190222084652.1326-1-anders.roxell@linaro.org>
On 02/22/2019 09:46 AM, Anders Roxell wrote:
> When running BPF test suite the following splat occurs:
>
> [ 415.930950] test_bpf: #0 TAX jited:0
> [ 415.931067] BUG: assuming atomic context at lib/test_bpf.c:6674
> [ 415.946169] in_atomic(): 0, irqs_disabled(): 0, pid: 11556, name: modprobe
> [ 415.953176] INFO: lockdep is turned off.
> [ 415.957207] CPU: 1 PID: 11556 Comm: modprobe Tainted: G W 5.0.0-rc7-next-20190220 #1
> [ 415.966328] Hardware name: HiKey Development Board (DT)
> [ 415.971592] Call trace:
> [ 415.974069] dump_backtrace+0x0/0x160
> [ 415.977761] show_stack+0x24/0x30
> [ 415.981104] dump_stack+0xc8/0x114
> [ 415.984534] __cant_sleep+0xf0/0x108
> [ 415.988145] test_bpf_init+0x5e0/0x1000 [test_bpf]
> [ 415.992971] do_one_initcall+0x90/0x428
> [ 415.996837] do_init_module+0x60/0x1e4
> [ 416.000614] load_module+0x1de0/0x1f50
> [ 416.004391] __se_sys_finit_module+0xc8/0xe0
> [ 416.008691] __arm64_sys_finit_module+0x24/0x30
> [ 416.013255] el0_svc_common+0x78/0x130
> [ 416.017031] el0_svc_handler+0x38/0x78
> [ 416.020806] el0_svc+0x8/0xc
>
> Rework so that preemption is disabled when we loop over function
> 'BPF_PROG_RUN(...)'.
> Commit 568f196756ad ("bpf: check that BPF programs run with preemption disabled")
> highlighted the issue.
(Technically not an issue in the test suite itself, but good to have same
guarantees everywhere in BPF_PROG_RUN().)
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Applied, thanks!
prev parent reply other threads:[~2019-02-25 21:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 8:46 [PATCH v2] bpf: test_bpf: turn of preemption in function __run_once Anders Roxell
2019-02-25 21:28 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31dccc3f-3355-31b6-87c1-81d9ff35515b@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).