From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424759AbcFMPyZ (ORCPT ); Mon, 13 Jun 2016 11:54:25 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:65204 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424417AbcFMPyY (ORCPT ); Mon, 13 Jun 2016 11:54:24 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Ben Dooks , linux-kernel@lists.codethink.co.uk, Ulf Hansson , Kevin Hilman , Alexander Aring , linux-kernel@vger.kernel.org, Eric Anholt Subject: Re: [PATCH] ARM: bcm2835: remove unused __packet Date: Mon, 13 Jun 2016 17:55:12 +0200 Message-ID: <3205257.80lYkVfUux@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk> References: <1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:AU2k62sEuAGB+toVjtiD0WE8ycryB+ijDJNCwNZzJt5HoQbXRkQ fmCSJESCwHgwKgsAEEYNqMKpqF2/hRUF9Czncpwjf5+9A87VLWDurgyChypesyi1tFQqDdy V1ttHVWPRc82uKdui+a1GzsN3tYn03k97Nzpna4DjeRx27v7di+E6Giv+Nj6XEg32XmyTK6 kAcJ3SZ7ySeNFzndEJojg== X-UI-Out-Filterresults: notjunk:1;V01:K0:sk1Bvjsfk6w=:sxnEaLH4rDE28maWmpGK2Y Yr4IG329H3iL2bnF00gCi75ugZtChEndK/GKidijLfu4yAgmcHjq6yp99yXkgcHgpidkJ7PYM NObSqdi4rickNWRZyPUA2gqq/AUhLCQrPOF4eCD2HDr9BiumHtsZSRtrdHnfm64gHuOijeojD OYCZZfB0fc/5ofgn/7U0Y2QFcylJ/3pnA8fDmfxjjsl2NQ1iD2V8W+RKSzTdPnbiLKePrgm2r fcDPO7qDGMxqYPMh1DIUsfk6CsMFsfTL2lhnOysb3pRPZ+y9AlDR9q9c6CzetjNjGuCiM0Sih cOq6wbbLH9rGSrwrSHfd7kEDmFmUzgBI31KRs0ehnuYNbQ35GyJMWOwMufnNsqlISmknQB45D 0W4WHdSiUJHJo6AKF8Y/P58NB1P1nBMMtETN0QIXCTawCRJaOe91RaNBjwuUyk+wz7hb5QWnD QPnwDJGOV06iITVbPoTdGg9m/bxGoEIkbfqQgdxw2kjW9PkZUudFZ5c8wYP/JZUkSVd5GQaQA RAWCp5OK6Jf/SLneZ1c+Cvw9SBeX6nA+Sb7rgM2yyI6C7Ob24t784lfG1EnMkwZkfPRWvzPk2 Elk0raEkrgSbje7eNCGa1hjTe2I2a8ei2nhO3CWEF6CD4T0BLeSLyenI8Mku3i4G/Uw4Vf+jo q8mRacfgYWXaNC/Yn0tmwXu8admwLw/oCHg/PenP9jA32pADwS7+qRj5SL98fG9U6X6L1RoWF Tofei8n0hSTUyBAj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, June 7, 2016 6:49:33 PM CEST Ben Dooks wrote: > The driver defines a variable called __packet but then never > uses it, and does not export it for others to use either. Fix > the warning about undeclared variable by removing it. > > drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static? > > Signed-off-by: Ben Dooks > --- The patch looks good, but it's probably worth mentioning here that this was intended to be the '__packed' attribute instead of a local variable. The attribute is useless here, as the variables both still get the default stack alignment, even if rpi_firmware_property only requires byte-aligned data. Arnd > diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c > index fe96a8b..f7ed118 100644 > --- a/drivers/soc/bcm/raspberrypi-power.c > +++ b/drivers/soc/bcm/raspberrypi-power.c > @@ -45,7 +45,7 @@ struct rpi_power_domains { > struct rpi_power_domain_packet { > u32 domain; > u32 on; > -} __packet; > +}; >