LKML Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the pm tree
@ 2019-09-10 14:33 Stephen Rothwell
  2019-09-11  7:27 ` Heikki Krogerus
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2019-09-10 14:33 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Heikki Krogerus

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi all,

In commit

  fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")

Fixes tag

  Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")

or

Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: Fixes tag needs some work in the pm tree
  2019-09-10 14:33 linux-next: Fixes tag needs some work in the pm tree Stephen Rothwell
@ 2019-09-11  7:27 ` Heikki Krogerus
  2019-09-11 17:17   ` Rafael J. Wysocki
  0 siblings, 1 reply; 7+ messages in thread
From: Heikki Krogerus @ 2019-09-11  7:27 UTC (permalink / raw)
  To: Stephen Rothwell, Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
> 
> Fixes tag
> 
>   Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Did you mean
> 
> Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
> 
> or
> 
> Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")

Rafael, it seems you have rebased your branch. Do you want me to
resend those fixes, or can you fix the tags in them yourself?

thanks,

-- 
heikki

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: Fixes tag needs some work in the pm tree
  2019-09-11  7:27 ` Heikki Krogerus
@ 2019-09-11 17:17   ` Rafael J. Wysocki
  2019-09-12  7:40     ` Heikki Krogerus
  0 siblings, 1 reply; 7+ messages in thread
From: Rafael J. Wysocki @ 2019-09-11 17:17 UTC (permalink / raw)
  To: Heikki Krogerus
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

On Wednesday, September 11, 2019 9:27:41 AM CEST Heikki Krogerus wrote:
> On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
> > 
> > Fixes tag
> > 
> >   Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
> > 
> > has these problem(s):
> > 
> >   - Subject does not match target commit subject
> >     Just use
> > 	git log -1 --format='Fixes: %h ("%s")'
> > 
> > Did you mean
> > 
> > Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
> > 
> > or
> > 
> > Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
> 
> Rafael, it seems you have rebased your branch.

No, I haven't.

Actually, the commit ID is correct, but the name isn't.

You'd have been unlikely to get a valid commit ID matching anything with
"software node" in the subject had it been rebased. :-)

> Do you want me to resend those fixes, or can you fix the tags in them
> yourself?

I fixed that tag up.

Thanks,
Rafael




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: Fixes tag needs some work in the pm tree
  2019-09-11 17:17   ` Rafael J. Wysocki
@ 2019-09-12  7:40     ` Heikki Krogerus
  0 siblings, 0 replies; 7+ messages in thread
From: Heikki Krogerus @ 2019-09-12  7:40 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

On Wed, Sep 11, 2019 at 07:17:52PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, September 11, 2019 9:27:41 AM CEST Heikki Krogerus wrote:
> > On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > In commit
> > > 
> > >   fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
> > > 
> > > Fixes tag
> > > 
> > >   Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
> > > 
> > > has these problem(s):
> > > 
> > >   - Subject does not match target commit subject
> > >     Just use
> > > 	git log -1 --format='Fixes: %h ("%s")'
> > > 
> > > Did you mean
> > > 
> > > Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
> > > 
> > > or
> > > 
> > > Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
> > 
> > Rafael, it seems you have rebased your branch.
> 
> No, I haven't.
> 
> Actually, the commit ID is correct, but the name isn't.
> 
> You'd have been unlikely to get a valid commit ID matching anything with
> "software node" in the subject had it been rebased. :-)

Ah. I've added the tag line manually (for some reason). I'm sorry
about that. I usually use this:

        % git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"

> > Do you want me to resend those fixes, or can you fix the tags in them
> > yourself?
> 
> I fixed that tag up.

Thanks Rafael!

-- 
heikki

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: Fixes tag needs some work in the pm tree
  2019-10-14 20:59 Stephen Rothwell
@ 2019-10-15 10:08 ` Rafael J. Wysocki
  0 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2019-10-15 10:08 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andy Shevchenko

On Monday, October 14, 2019 10:59:04 PM CEST Stephen Rothwell wrote:
> 
> --Sig_/eM_f_lhAmw+jp3bqTr5YSMd
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi all,
> 
> In commit
> 
>   b2afd668c323 ("ACPI / utils: Move acpi_dev_get_first_match_dev() under CO=
> NFIG_ACPI")
> 
> Fixes tag
> 
>   Fixes: 817b4d64da03 ("Introduce acpi_dev_get_first_match_dev() helper")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject

Fixed, thanks!




^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: Fixes tag needs some work in the pm tree
@ 2019-10-14 20:59 Stephen Rothwell
  2019-10-15 10:08 ` Rafael J. Wysocki
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2019-10-14 20:59 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andy Shevchenko

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi all,

In commit

  b2afd668c323 ("ACPI / utils: Move acpi_dev_get_first_match_dev() under CONFIG_ACPI")

Fixes tag

  Fixes: 817b4d64da03 ("Introduce acpi_dev_get_first_match_dev() helper")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: Fixes tag needs some work in the pm tree
@ 2019-07-10 11:26 Stephen Rothwell
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2019-07-10 11:26 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Wen Yang

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

Hi all,

In commit

  f43e075f7252 ("cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init()")

Fixes tag

  Fixes: a9acc26b75f ("cpufreq/pasemi: fix possible object reference leak")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 14:33 linux-next: Fixes tag needs some work in the pm tree Stephen Rothwell
2019-09-11  7:27 ` Heikki Krogerus
2019-09-11 17:17   ` Rafael J. Wysocki
2019-09-12  7:40     ` Heikki Krogerus
  -- strict thread matches above, loose matches on Subject: below --
2019-10-14 20:59 Stephen Rothwell
2019-10-15 10:08 ` Rafael J. Wysocki
2019-07-10 11:26 Stephen Rothwell

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox