From: "Filipe Laíns" <lains@archlinux.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: logitech-dj: add debug msg when exporting a HID++ report descriptors
Date: Tue, 14 Jan 2020 01:47:23 +0000 [thread overview]
Message-ID: <320e6e0d7f8968b3febb3422ba02a2b249e09f60.camel@archlinux.org> (raw)
In-Reply-To: <CAO-hwJKkMv7T0e11XoYKh9GtsnNCfOztFsoU7JXgmxCvfROeZw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]
On Tue, 2020-01-14 at 11:24 +1000, Benjamin Tissoires wrote:
> Hi Filipe,
>
> On Tue, Jan 14, 2020 at 5:23 AM Filipe Laíns <lains@archlinux.org> wrote:
> > When exporting all other types of report descriptors we print a debug
> > message. Not doing so for HID++ descriptors makes unaware users think
> > that no HID++ descriptor was exported.
>
> Unless I am mistaken, those dbg_hid() calls are not displayed by
> default on any distribution. So I am not sure what is the benefit to
> add this one here when we are already not showing the rest to the
> users by default. There is a tiny improvement to have some code
> symmetry, but here, honestly, it doesn't feel that required.
>
> Cheers,
> Benjamin
Hi Benjamin,
As far as I know, they aren't. This was just a nitpick. As I already
had the code locally I decided to just go ahead and submit the patch.
But noted, I won't submit any more of this nitpick patches.
> > Signed-off-by: Filipe Laíns <lains@archlinux.org>
> > ---
> > drivers/hid/hid-logitech-dj.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> > index cc7fc71d8b05..8f17a29b5a94 100644
> > --- a/drivers/hid/hid-logitech-dj.c
> > +++ b/drivers/hid/hid-logitech-dj.c
> > @@ -1368,6 +1368,8 @@ static int logi_dj_ll_parse(struct hid_device *hid)
> > }
> >
> > if (djdev->reports_supported & HIDPP) {
> > + dbg_hid("%s: sending a HID++ descriptor, reports_supported: %llx\n",
> > + __func__, djdev->reports_supported);
> > rdcat(rdesc, &rsize, hidpp_descriptor,
> > sizeof(hidpp_descriptor));
> > }
> > --
> > 2.24.1
> >
Thank you,
Filipe Laíns
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-14 1:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 19:23 [PATCH] HID: logitech-dj: add debug msg when exporting a HID++ report descriptors Filipe Laíns
2020-01-14 1:24 ` Benjamin Tissoires
2020-01-14 1:47 ` Filipe Laíns [this message]
2020-02-12 13:45 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=320e6e0d7f8968b3febb3422ba02a2b249e09f60.camel@archlinux.org \
--to=lains@archlinux.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).