From: Eddie James <eajames@linux.ibm.com>
To: Joel Stanley <joel@jms.id.au>,
Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Andrew Jeffery <andrew@aj.id.au>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] media: aspeed: Rework memory mapping in probe
Date: Tue, 7 Jan 2020 13:16:57 -0600 [thread overview]
Message-ID: <3237d298-066c-60f0-9912-b32f5bdecfd0@linux.ibm.com> (raw)
In-Reply-To: <20200107034324.38073-2-joel@jms.id.au>
On 1/6/20 9:43 PM, Joel Stanley wrote:
> Use the recently introduced function devm_platform_ioremap_resource to
> save a few lines of code. This makes the driver match common platform
> device probe patterns.
Reviewed-by: Eddie James <eajames@linux.ibm.com>
Thanks Joel!
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/media/platform/aspeed-video.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
> index d8593cb2ae84..8f849d9866af 100644
> --- a/drivers/media/platform/aspeed-video.c
> +++ b/drivers/media/platform/aspeed-video.c
> @@ -1655,14 +1655,17 @@ static int aspeed_video_init(struct aspeed_video *video)
>
> static int aspeed_video_probe(struct platform_device *pdev)
> {
> + struct aspeed_video *video;
> int rc;
> - struct resource *res;
> - struct aspeed_video *video =
> - devm_kzalloc(&pdev->dev, sizeof(*video), GFP_KERNEL);
>
> + video = devm_kzalloc(&pdev->dev, sizeof(*video), GFP_KERNEL);
> if (!video)
> return -ENOMEM;
>
> + video->base = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(video->base))
> + return PTR_ERR(video->base);
> +
> video->frame_rate = 30;
> video->dev = &pdev->dev;
> spin_lock_init(&video->lock);
> @@ -1671,13 +1674,6 @@ static int aspeed_video_probe(struct platform_device *pdev)
> INIT_DELAYED_WORK(&video->res_work, aspeed_video_resolution_work);
> INIT_LIST_HEAD(&video->buffers);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> - video->base = devm_ioremap_resource(video->dev, res);
> -
> - if (IS_ERR(video->base))
> - return PTR_ERR(video->base);
> -
> rc = aspeed_video_init(video);
> if (rc)
> return rc;
next prev parent reply other threads:[~2020-01-07 19:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 3:43 [PATCH 0/3] video: aspeed video engine cleanups Joel Stanley
2020-01-07 3:43 ` [PATCH 1/3] media: aspeed: Rework memory mapping in probe Joel Stanley
2020-01-07 17:20 ` Jae Hyun Yoo
2020-01-07 19:16 ` Eddie James [this message]
2020-01-07 3:43 ` [PATCH 2/3] media: aspeed: Use runtime configuration Joel Stanley
2020-01-07 17:33 ` Jae Hyun Yoo
2020-01-07 19:18 ` Eddie James
2020-01-07 3:43 ` [PATCH 3/3] video: aspeed: Update copyright information Joel Stanley
2020-01-07 17:55 ` Jae Hyun Yoo
2020-01-07 19:18 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3237d298-066c-60f0-9912-b32f5bdecfd0@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).