From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756175AbdKGW4z convert rfc822-to-8bit (ORCPT ); Tue, 7 Nov 2017 17:56:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35972 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755305AbdKGW4y (ORCPT ); Tue, 7 Nov 2017 17:56:54 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E9C84883C9 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <877ev2rnt1.fsf@linux.vnet.ibm.com> References: <877ev2rnt1.fsf@linux.vnet.ibm.com> <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> <150842464774.7923.7951986297563109339.stgit@warthog.procyon.org.uk> To: Thiago Jung Bauermann Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org, matthew.garrett@nebula.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jforbes@redhat.com Subject: Re: [PATCH 02/27] Add a SysRq option to lift kernel lockdown MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Date: Tue, 07 Nov 2017 22:56:51 +0000 Message-ID: <32418.1510095411@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 07 Nov 2017 22:56:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thiago Jung Bauermann wrote: > On non-x86 platforms (tested on powerpc) this fails to build with: > > security/lock_down.c: In function ‘lockdown_lift_sysrq’: > security/lock_down.c:100:40: error: ‘LOCKDOWN_LIFT_KEY’ undeclared (first use in this function) > lockdown_lift_sysrq_op.help_msg[5] = LOCKDOWN_LIFT_KEY; > ^~~~~~~~~~~~~~~~~ > security/lock_down.c:100:40: note: each undeclared identifier is reported only once for each function it appears in I've added an arch dependency in the Kconfig file in my local branch. I'll try to get it pushed again. David