From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758826Ab2JXVIV (ORCPT ); Wed, 24 Oct 2012 17:08:21 -0400 Received: from ogre.sisk.pl ([193.178.161.156]:35430 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447Ab2JXVIT (ORCPT ); Wed, 24 Oct 2012 17:08:19 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-dev@lists.linaro.org, patches@linaro.org, pdsw-power-team@arm.com, arvind.chauhan@arm.com Subject: Re: [PATCH 2/2] cpufreq: governors: remove redundant code Date: Wed, 24 Oct 2012 23:12:13 +0200 Message-ID: <3245066.cWfgP9Ikey@vostro.rjw.lan> User-Agent: KMail/4.8.5 (Linux/3.6.2-6-desktop; KDE/4.8.5; x86_64; ; ) In-Reply-To: <1597360.JT7plJlUsZ@vostro.rjw.lan> References: <32e5bed743cc6cc4e614291a7080299f5f0d0933.1350677395.git.viresh.kumar@linaro.org> <1597360.JT7plJlUsZ@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 24 of October 2012 21:43:46 Rafael J. Wysocki wrote: > On Wednesday 24 of October 2012 11:37:13 Viresh Kumar wrote: > > On 22 October 2012 14:16, Viresh Kumar wrote: > > > On 20 October 2012 01:42, Viresh Kumar wrote: > > >> Initially ondemand governor was written and then using its code conservative > > >> governor is written. It used a lot of code from ondemand governor, but copy of > > >> code was created instead of using the same routines from both governors. Which > > >> increased code redundancy, which is difficult to manage. > > >> > > >> This patch is an attempt to move common part of both the governors to > > >> cpufreq_governor.c file to come over above mentioned issues. > > >> > > >> This shouldn't change anything from functionality point of view. > > >> > > >> Signed-off-by: Viresh Kumar > > > > For everybody else, this patch is already pushed by Rafael in his linux-next > > branch. > > Well, not yet, although I'm going to do that. Or I would if it still applied. Unfortunately, though, it doesn't apply any more to my linux-next branch due to some previous changes in it. Care to rebase? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.