From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F66C4338F for ; Mon, 16 Aug 2021 07:01:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CED5361A7A for ; Mon, 16 Aug 2021 07:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233736AbhHPHBy (ORCPT ); Mon, 16 Aug 2021 03:01:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233485AbhHPHBx (ORCPT ); Mon, 16 Aug 2021 03:01:53 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5A90C061764 for ; Mon, 16 Aug 2021 00:01:21 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id v2so14436055edq.10 for ; Mon, 16 Aug 2021 00:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ak4JwnrZ9gSNOvvGFAQ1po2LI2/cEmkml+wEnVfkQng=; b=R/UrMnFVb7gCuoZ0nclUlvcJzMkhaDIK2+SebUsSpiqjxYvE2C0KV4xOd1R/X0P3Xn yruSF2G73sMVQ+CXBt5q1CBLYMEZzy74jABciHN51MfWVf7ABADlmOYMeGMysnXNBmaH zGRLmV4/ySeJr4EnZirbW8zw6RYcICeqUP6O0B1PyUYoRi75eb/J4SPrUYpi4OlnTxz6 yfyMMplkcetY7VB1H6FL5UdPUjNTY9YZCxdYVm5FwQO50Yq1fvWpI68QQgjD6fdoWWT4 FjII11fhmHMdW3Efc3cuZiQRONUka/5Y5jpX6VGTgN+5nxmsSUY15pr8KMVbgYtY3F0v j60Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ak4JwnrZ9gSNOvvGFAQ1po2LI2/cEmkml+wEnVfkQng=; b=smJymObbUC/kFwX7irvE52O0QOFWzHpUIMfg8DbaDp2NOJUhAjofjRsg6JgMGyuR0u V91JNw8jeIidyQxx2Xxjxpn4WB8VnZbDG9Dd1tx3chW9Ac+slhmqgibQbWRg8l2U0+sP Ojs4leWdmi5dKoLa95v3AZ/F5H99buK/7SPnrGRIxcXqDRv9wqwimkatZZCup508Yl5J y3vi+Lo5wzFiIrfD0IGVs8/WRGhCo/EsspRZS/moJ3/u0oUGdtd8UTJsyg1CNu9zilv6 wHyNCHX1Dqsa0I4l7DFEIzVwoRLuifiPVPIoj4pVRDIW3PcmFgE6iN6m115qrAbaEGWH 3AYw== X-Gm-Message-State: AOAM531uRlIsxPywOLrLFq3UQiCOkO9IGdWC3PiUVXreo6lHKfP8Zsoo 6D9HiHOW0So/UjOfaomm+cc= X-Google-Smtp-Source: ABdhPJyJf/DefOj/TjYvwmRafKSAcggJ5p8fRXMflb7Mz8yNO0XlfQ+EcmG7RgOLK8CxfVZwYdymtw== X-Received: by 2002:aa7:ce87:: with SMTP id y7mr18354452edv.306.1629097280526; Mon, 16 Aug 2021 00:01:20 -0700 (PDT) Received: from localhost.localdomain (host-79-22-109-211.retail.telecomitalia.it. [79.22.109.211]) by smtp.gmail.com with ESMTPSA id a25sm3289600ejv.91.2021.08.16.00.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 00:01:20 -0700 (PDT) From: "Fabio M. De Francesco" To: gregkh@linuxfoundation.org, Phillip Potter Cc: Larry.Finger@lwfinger.net, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: remove unused variable and DBG_88E in hal/rtl8188e_cmd.c Date: Mon, 16 Aug 2021 09:01:16 +0200 Message-ID: <325822103.EpFXLVovdo@localhost.localdomain> In-Reply-To: <11475165.p2zfeMNkXv@localhost.localdomain> References: <20210815230518.91656-1-phil@philpotter.co.uk> <11475165.p2zfeMNkXv@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, August 16, 2021 8:55:06 AM CEST Fabio M. De Francesco wrote: > On Monday, August 16, 2021 1:05:18 AM CEST Phillip Potter wrote: > > Remove set but unused variable init_rate from rtl8188e_Add_RateATid > > function in hal/rtl8188e_cmd.c, as it fixes a kernel test robot warning. > > Removing the call to get_highest_rate_idx has no side effects here so is > > safe. > > > > Also remove the DBG_88E macro call in this function, as it is not > > particularly clear in my opinion. Additionally, rename variable > > shortGIrate to short_gi_rate to conform to kernel camel case rules, > > and improve general spacing around operators, some of which triggers > > checkpatch 'CHECK' messages. These are not related to the test robot > > warning. > > > > Reported-by: kernel test robot > > Signed-off-by: Phillip Potter > > --- > > > > drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 22 +++++++--------------- > > 1 file changed, 7 insertions(+), 15 deletions(-) > > Dear Philip, > > I'm sorry but, although every change here is fine, I cannot ack your patch as- > is. It shouldn't address so many different issues all at once, according to > the best practices in patching and the kernel development rules. > > I understand that you think that, while you are at the removal of "init_rate", > why shouldn't I address all other trivial issues at once? > > Even if the patch is short and it probably doesn't require particular hard > effort to review it, that mix-up of different works shouldn't be done, mainly > because this attitude could potentially lead you to add more and more > different work in future patches. Where is the limit? Why not add some more > different works next time you find some more problems into the same file/ > directory? > > If I were you I'd, at least, prepare a series of two or three patches: > > 1/3 - Remove init_rate as reported by KTR; > 2/3 - Remove unneeded DBG_88E macro; > 3/3 - Do some clean-up of rtl8188e_cmd.c; > > Perhaps patches 2/3 and 3/3 could be merged into one, but I'm not really sure. > > Thanks, > > Fabio Furthermore, I forgot to say that the "Subject" should summarize with few words the whole work you do and in this case it is not what it does. Fabio