From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5D3C7EE2D for ; Wed, 24 May 2023 17:08:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234351AbjEXRI3 (ORCPT ); Wed, 24 May 2023 13:08:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231785AbjEXRI2 (ORCPT ); Wed, 24 May 2023 13:08:28 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19E24E9; Wed, 24 May 2023 10:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=r17O1HkJRKeCWfCU23f/nGpxZ/B8ZzxbRelEQsNBLw4=; b=1s g8ej3AKHcZ4ViO1gAz74HlE0le/ophkG98WfMcUCiEPkG0AKTbydHZBJjwloV72V377oTJ7QFmYmf ZMZgpkc/ETREaXC15aFszRY075heYjXgKPZp52xOM54u2j2AOQfhLmwfAJsf8Y9st5a8FNgcVlb9E aF/MwptQLpMRYJs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1q1ryE-00DodW-Oq; Wed, 24 May 2023 19:08:18 +0200 Date: Wed, 24 May 2023 19:08:18 +0200 From: Andrew Lunn To: Alexis =?iso-8859-1?Q?Lothor=E9?= Cc: "Russell King (Oracle)" , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Thomas Petazzoni , paul.arola@telus.com, scott.roberts@telus.com, Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH net-next v3 2/7] net: dsa: mv88e6xxx: pass directly chip structure to mv88e6xxx_phy_is_internal Message-ID: <325a6737-21b9-4b78-b022-9a540c3c0f33@lunn.ch> References: <20230524130127.268201-1-alexis.lothore@bootlin.com> <20230524130127.268201-3-alexis.lothore@bootlin.com> <9a7fac7b-e04b-27e2-8679-ffbbb23c248e@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9a7fac7b-e04b-27e2-8679-ffbbb23c248e@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 04:46:35PM +0200, Alexis Lothoré wrote: > Hello Russell, > > On 5/24/23 15:18, Russell King (Oracle) wrote: > > On Wed, May 24, 2023 at 03:01:22PM +0200, Alexis Lothoré wrote: > >> Since this function is a simple helper, we do not need to pass a full > >> dsa_switch structure, we can directly pass the mv88e6xxx_chip structure. > >> Doing so will allow to share this function with any other function > >> not manipulating dsa_switch structure but needing info about number of > >> internal phys > >> > >> Reviewed-by: Russell King (Oracle) > >> Reviewed-by: Florian Fainelli > >> > >> --- > >> Changes since v2: > >> - add reviewed-by tags > >> > >> Signed-off-by: Alexis Lothoré > >> --- > > > > It never ceases to amaze me the way human beings can find creative ways > > to mess things up, no matter how well things are documented. The above > > commit message (and the others that I've looked at) are all broken > > because of this creativity. > > > > In effect, because of the really weird format you've come up with here, > > your patches are in effect *not* signed off by you. > > Sorry for that. This was an attempt to provide relevant changelog for each > patch, but obviously the way I stored those changelogs was wrong, and I did not > catch the consequent broken Signed-off-by lines after re-generating the series. > I'll do as suggested and hold off a bit before fixing/re-sending. You can put the changelog in the commit message in git commit, you just need to add the correct --- separate after the tags. The patch created with git format-patch will then have two ---, but that is not a problem. Andrew --- pw-bot: cr