From: Juergen Gross <jgross@suse.com>
To: Xunlei Pang <xlpang@redhat.com>,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org
Cc: akpm@linux-foundation.org, Eric Biederman <ebiederm@xmission.com>,
Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
Petr Tesarik <ptesarik@suse.cz>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
Michael Holzheu <holzheu@linux.vnet.ibm.com>
Subject: Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section
Date: Thu, 20 Apr 2017 16:24:41 +0200 [thread overview]
Message-ID: <325a8a1b-8f52-b05d-3b7f-440f365dfbbc@suse.com> (raw)
In-Reply-To: <1492688374-27903-1-git-send-email-xlpang@redhat.com>
On 20/04/17 13:39, Xunlei Pang wrote:
> As Eric said,
> "what we need to do is move the variable vmcoreinfo_note out
> of the kernel's .bss section. And modify the code to regenerate
> and keep this information in something like the control page.
>
> Definitely something like this needs a page all to itself, and ideally
> far away from any other kernel data structures. I clearly was not
> watching closely the data someone decided to keep this silly thing
> in the kernel's .bss section."
>
> This patch allocates extra pages for these vmcoreinfo_XXX variables,
> one advantage is that it enhances some safety of vmcoreinfo, because
> vmcoreinfo now is kept far away from other kernel data structures.
>
> Suggested-by: Eric Biederman <ebiederm@xmission.com>
> Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> Cc: Juergen Gross <jgross@suse.com>
> Signed-off-by: Xunlei Pang <xlpang@redhat.com>
Xen parts: Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
next prev parent reply other threads:[~2017-04-20 14:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 11:39 [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section Xunlei Pang
2017-04-20 11:39 ` [PATCH v4 2/3] powerpc/fadump: Use the correct VMCOREINFO_NOTE_SIZE for phdr Xunlei Pang
2017-04-21 0:55 ` Xunlei Pang
2017-04-26 7:11 ` Dave Young
2017-04-27 7:38 ` Mahesh Jagannath Salgaonkar
2017-04-20 11:39 ` [PATCH v4 3/3] kdump: Protect vmcoreinfo data under the crash memory Xunlei Pang
2017-04-26 7:09 ` Dave Young
2017-04-26 9:21 ` Xunlei Pang
2017-04-27 2:56 ` Dave Young
2017-04-20 14:24 ` Juergen Gross [this message]
2017-04-24 15:18 ` [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section Michael Holzheu
2017-04-26 7:19 ` Dave Young
2017-04-26 9:51 ` Xunlei Pang
2017-04-26 10:18 ` Xunlei Pang
2017-04-27 3:06 ` Dave Young
2017-04-27 5:25 ` Xunlei Pang
2017-04-27 5:44 ` Dave Young
2017-04-27 6:08 ` Xunlei Pang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=325a8a1b-8f52-b05d-3b7f-440f365dfbbc@suse.com \
--to=jgross@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hbathini@linux.vnet.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptesarik@suse.cz \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).