From: Joe Perches <joe@perches.com>
To: Amir Mahdi Ghorbanian <indigoomega021@gmail.com>, marvin24@gmx.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, ac100@lists.launchpad.net,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] Staging: nvec: nvec: fixed check style issues
Date: Sun, 16 Dec 2018 14:30:01 -0800 [thread overview]
Message-ID: <325ac79885892082f4a5b9fe294178d59c2ced68.camel@perches.com> (raw)
In-Reply-To: <1544996634-10427-1-git-send-email-indigoomega021@gmail.com>
On Sun, 2018-12-16 at 13:43 -0800, Amir Mahdi Ghorbanian wrote:
> Replaced udelay() by the preferred usleep_range() function.
[]
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
[]
> @@ -626,7 +626,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> break;
> case 2: /* first byte after command */
> if (status == (I2C_SL_IRQ | RNW | RCVD)) {
> - udelay(33);
> + usleep_range(0, 33);
Umm, this is not the same outcome.
udelay delays a minimum of 33 usecs.
usleep_range delays from min to max usecs.
kernel/time/timer.c: * usleep_range - Sleep for an approximate time
kernel/time/timer.c- * @min: Minimum time in usecs to sleep
kernel/time/timer.c- * @max: Maximum time in usecs to sleep
kernel/time/timer.c- *
kernel/time/timer.c- * In non-atomic context where the exact wakeup time is flexible, use
kernel/time/timer.c: * usleep_range() instead of udelay(). The sleep improves responsiveness
kernel/time/timer.c- * by avoiding the CPU-hogging busy-wait of udelay(), and the range reduces
kernel/time/timer.c- * power usage by allowing hrtimers to take advantage of an already-
kernel/time/timer.c- * scheduled interrupt instead of scheduling a new one just for this sleep.
kernel/time/timer.c- */
> if (nvec->rx->data[0] != 0x01) {
> dev_err(nvec->dev,
> "Read without prior read command\n");
> @@ -713,7 +713,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> * We experience less incomplete messages with this delay than without
> * it, but we don't know why. Help is appreciated.
> */
> - udelay(100);
> + usleep_range(0, 100);
here too.
next prev parent reply other threads:[~2018-12-16 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 21:43 [PATCH] Staging: nvec: nvec: fixed check style issues Amir Mahdi Ghorbanian
2018-12-16 22:30 ` Joe Perches [this message]
2018-12-16 23:02 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=325ac79885892082f4a5b9fe294178d59c2ced68.camel@perches.com \
--to=joe@perches.com \
--cc=ac100@lists.launchpad.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=indigoomega021@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).