From: Paolo Bonzini <pbonzini@redhat.com>
To: linmiaohe <linmiaohe@huawei.com>,
rkrcmar@redhat.com, sean.j.christopherson@intel.com,
vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2] KVM: nVMX: Fix some comment typos and coding style
Date: Wed, 12 Feb 2020 12:55:32 +0100 [thread overview]
Message-ID: <326b6411-d88d-5522-8296-6486d282a512@redhat.com> (raw)
In-Reply-To: <1581088965-3334-1-git-send-email-linmiaohe@huawei.com>
On 07/02/20 16:22, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> Fix some typos in the comments. Also fix coding style.
> [Sean Christopherson rewrites the comment of write_fault_to_shadow_pgtable
> field in struct kvm_vcpu_arch.]
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> v1->v2:
> Use Sean Christopherson' comment for write_fault_to_shadow_pgtable
> ---
> arch/x86/include/asm/kvm_host.h | 16 +++++++++++++---
> arch/x86/kvm/vmx/nested.c | 5 +++--
> 2 files changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 4dffbc10d3f8..40a0c0fd95ca 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -781,9 +781,19 @@ struct kvm_vcpu_arch {
> u64 msr_kvm_poll_control;
>
> /*
> - * Indicate whether the access faults on its page table in guest
> - * which is set when fix page fault and used to detect unhandeable
> - * instruction.
> + * Indicates the guest is trying to write a gfn that contains one or
> + * more of the PTEs used to translate the write itself, i.e. the access
> + * is changing its own translation in the guest page tables. KVM exits
> + * to userspace if emulation of the faulting instruction fails and this
> + * flag is set, as KVM cannot make forward progress.
> + *
> + * If emulation fails for a write to guest page tables, KVM unprotects
> + * (zaps) the shadow page for the target gfn and resumes the guest to
> + * retry the non-emulatable instruction (on hardware). Unprotecting the
> + * gfn doesn't allow forward progress for a self-changing access because
> + * doing so also zaps the translation for the gfn, i.e. retrying the
> + * instruction will hit a !PRESENT fault, which results in a new shadow
> + * page and sends KVM back to square one.
> */
> bool write_fault_to_shadow_pgtable;
>
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 657c2eda357c..e7faebccd733 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -544,7 +544,8 @@ static void nested_vmx_disable_intercept_for_msr(unsigned long *msr_bitmap_l1,
> }
> }
>
> -static inline void enable_x2apic_msr_intercepts(unsigned long *msr_bitmap) {
> +static inline void enable_x2apic_msr_intercepts(unsigned long *msr_bitmap)
> +{
> int msr;
>
> for (msr = 0x800; msr <= 0x8ff; msr += BITS_PER_LONG) {
> @@ -1981,7 +1982,7 @@ static int nested_vmx_handle_enlightened_vmptrld(struct kvm_vcpu *vcpu,
> }
>
> /*
> - * Clean fields data can't de used on VMLAUNCH and when we switch
> + * Clean fields data can't be used on VMLAUNCH and when we switch
> * between different L2 guests as KVM keeps a single VMCS12 per L1.
> */
> if (from_launch || evmcs_gpa_changed)
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-02-12 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 15:22 [PATCH v2] KVM: nVMX: Fix some comment typos and coding style linmiaohe
2020-02-07 16:25 ` Vitaly Kuznetsov
2020-02-12 11:55 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=326b6411-d88d-5522-8296-6486d282a512@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).