From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbdALN0l (ORCPT ); Thu, 12 Jan 2017 08:26:41 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:49224 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbdALN0k (ORCPT ); Thu, 12 Jan 2017 08:26:40 -0500 From: Arnd Bergmann To: Will Deacon Cc: Nikita Yushchenko , Robin Murphy , linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Simon Horman , Bjorn Helgaas , fkan@apm.com, linux-kernel@vger.kernel.org, Artemi Ivanov Subject: Re: [PATCH 1/2] dma-mapping: let arch know origin of dma range passed to arch_setup_dma_ops() Date: Thu, 12 Jan 2017 14:25:54 +0100 Message-ID: <3273119.LjYLKcrNcz@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20170112121623.GH1771@arm.com> References: <764334db-3400-58c6-cc4b-3f7ce66daa27@cogentembedded.com> <20170112121623.GH1771@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:3WZ2Qv+VRpkZVO1mcMqd2m/y/vgLNDpYOn6xJZOk/8SZahA33UV OgtMnr6KxD/y1LOrl++X7D42zDDNV+Cc+n/czkA/+Yp8RlyLbsfpNderqzmQIc61xDQFK6m ilI5e3oW8vXIjHX5+OuqG/8K6X3WbulzJq/zCUEiKPzMJRvlP4Fz2UscJzhtN6Mhk2Vdf5B YzSr1Vt01EhDt1++dFdOA== X-UI-Out-Filterresults: notjunk:1;V01:K0:RWPyagC7JfY=:NsjJcEeKo20aj+3FPtZYEJ SuckjBg+L/5owtgkueUUEQKE8ueJfP+6pgYSVnuzTDHSVnm02HFQa59cEpGsoTP99fpMCh8PG BDxW+oUafBme+ClgCFdNW/0wiWqUQwC3cSFmr5ZEX+XPR/nt60VrtTbE9dKZPoUCloNax3EB4 P++atArSMsG9BJM33Y+fBmJZqDqWa3dyBLdQ1FqwQc33RvzDtLOq6QknqBBri0YRa2wkB+89n oMJWlrrhc7u4FBDXUNJa96Pb8wXup5xD7j9Jenl0qKCzJPzCkHLdl6tY4LBYfUjP8rdqHnyCW W8jat4jOLt/FXvVglJ7Pj6IaO6WEPmwNuJmZNnlEkppL9GzJN/rl4UcPKKe9hmpY/4+/SDg9R 3n7YAMONaNZacYYrbBS7Q9sVwlysCCI9Blztn4NaCWvcJgjYl2gk/TnVPu+pNxiUzhvuVifZ4 IEM4RKWDPrcpjRuqnnx0qslRCBWqce7k/aqEmQRgU6T91CkhDdctMoT5UpOKelWwx/sNPyMM1 yDDCI04X800ChXpzwIKHNh+tg6tizYbMpmr0+NiL5p/MxtlojywllYlwF9WK8+61ko6xPvyAr qotKyKFs19oi48kzLd6Y/JGobdctoA+smPsTezLVcpWVXRMvRH1oLOyTRAwigObfM5+DJbfQR UWH1DvEs0k94lcgw+pBvmyzwoKEXSgC12w53LYjnyv2PRscEORcrm4NyfvDX/LDN/dKIYZ71K 7H9QP0t1SSLmGj0s Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, January 12, 2017 12:16:24 PM CET Will Deacon wrote: > On Thu, Jan 12, 2017 at 08:52:51AM +0300, Nikita Yushchenko wrote: > > >> diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c > > >> index 5ac373c..480b644 100644 > > >> --- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c > > >> +++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c > > >> @@ -540,7 +540,7 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc, > > >> > > >> /* Objects are coherent, unless 'no shareability' flag set. */ > > >> if (!(obj_desc->flags & DPRC_OBJ_FLAG_NO_MEM_SHAREABILITY)) > > >> - arch_setup_dma_ops(&mc_dev->dev, 0, 0, NULL, true); > > >> + arch_setup_dma_ops(&mc_dev->dev, 0, 0, false, NULL, true); > > >> > > >> /* > > >> * The device-specific probe callback will get invoked by device_add() > > > > > > Why are these actually calling arch_setup_dma_ops() here in the first > > > place? Are these all devices that are DMA masters without an OF node? > > > > I don't know, but that's a different topic. This patch just adds > > argument and sets it to false everywhere but in the location when range > > should be definitely enforced. > > I also wouldn't lose any sleep over a staging driver. I think this is in the process of being moved out of staging, and my question was about the other two as well: drivers/net/ethernet/freescale/dpaa/dpaa_eth.c drivers/iommu/rockchip-iommu.c Arnd