From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 987FFC4338F for ; Thu, 19 Aug 2021 03:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 829B4610E5 for ; Thu, 19 Aug 2021 03:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232110AbhHSDO5 (ORCPT ); Wed, 18 Aug 2021 23:14:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbhHSDO4 (ORCPT ); Wed, 18 Aug 2021 23:14:56 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC034C061764 for ; Wed, 18 Aug 2021 20:14:20 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id qk33so9525720ejc.12 for ; Wed, 18 Aug 2021 20:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Al99W6tKyxYHjbJ2Qjp5kd15/Fm62/1U7Do8PSyEWXg=; b=EO2bvA+kQXMWrCqWzca5o/U+vXXRSESK+ih0tu4JNs2dn3wf0+N+mNdrzYw3KEQUYf a8jY988/KdWqnHhpi/BVgsn3FazvDXe4ylOo++mPGrc9XA9XHDLIM8bZDiBZrLBQH55I 6HfacOnxvuM0tfRHdC5dGQ/hqOhSrW2Ymoj9R7bDT5W/frf5Gls55bbDbCdIIgcDkc0k 2iwfUKX0SN2arIFJjA7Av0CzamYqNTSjYUZYZK8J1j/LFL6sQoc5yfj2kMnQDwM8FAYS arrbw295YuvpxVaUuXNXJMB5G1SP0ynvsr3Rcj6XuFFfO9FzACJcqH9bLt98hF/KrPLg rDFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Al99W6tKyxYHjbJ2Qjp5kd15/Fm62/1U7Do8PSyEWXg=; b=kW2+zvHCZRMoIepqkvHTqm7VMf8UbH+Dgvs2YOBJ6y2hRSMGDrBqLkfLutMXTVCQUQ tKr7doTQ/7XvJsJzdJSvmem/0UAMoQvnyPg0dVvf6Mbe4k6V/3qn40Ue5DvpmkfujNI8 D540gdUsDqrLZ1sb3iN/7zgITltGM0zsowdnxYo7vVh8bnlM9w0T/SVaRtzroFI9D/GD xX6RaokVCdzzxal3Z3UlqTiJZ8aGXF6AkFWIdtmfyN9kq10BeSJVaR9t8IU9newdhkTU h+V0PM5UrlJN1mRSRLy404dSnNW3RGQEQTAdvTups2ZPsehdC2eKAzDaf2rFEY7mh2nn jOdA== X-Gm-Message-State: AOAM531B35Dz1uqpaAOe/TQSTboi/ICQOVr88g6dPCgYcOi12nbbMEMS ieUMzfKF+h7PqGMODOrlocs= X-Google-Smtp-Source: ABdhPJz495JBMb4ph6mVEuwYysnbQqtbSvnEwWe2aT/rYtAmQiyFG3mVOol2uLUwSb0536EHwwiHMw== X-Received: by 2002:a17:906:eb53:: with SMTP id mc19mr13270707ejb.22.1629342859257; Wed, 18 Aug 2021 20:14:19 -0700 (PDT) Received: from localhost.localdomain (host-79-22-109-211.retail.telecomitalia.it. [79.22.109.211]) by smtp.gmail.com with ESMTPSA id g10sm630356ejj.44.2021.08.18.20.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 20:14:18 -0700 (PDT) From: "Fabio M. De Francesco" To: gregkh@linuxfoundation.org, Phillip Potter Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, martin@kaiser.cx, straube.linux@gmail.com, Larry.Finger@lwfinger.net Subject: Re: [PATCH 6/6] staging: r8188eu: remove free_xmit_priv field from struct hal_ops Date: Thu, 19 Aug 2021 05:14:17 +0200 Message-ID: <3280989.scCUJ3VkD9@localhost.localdomain> In-Reply-To: <20210818234253.208271-7-phil@philpotter.co.uk> References: <20210818234253.208271-1-phil@philpotter.co.uk> <20210818234253.208271-7-phil@philpotter.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, August 19, 2021 1:42:53 AM CEST Phillip Potter wrote: > Remove free_xmit_priv function pointer field from struct hal_ops definition > in include/hal_intf.h, as it is now no longer used anywhere in the driver. > > Signed-off-by: Phillip Potter > --- > drivers/staging/r8188eu/include/hal_intf.h | 1 - > 1 file changed, 1 deletion(-) This entry could have been removed in patch 4/6 or 5/6, but I guess it's okay to do that here as well. Perhaps the three patches from 4/6 to 6/6 could have been merged into one (because since 4/6 was immediately clear that this operation has no use at all). Aside from the above considerations, it looks good. So... Acked by: Fabio M. De Francesco Thanks, Fabio