From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752470AbcHZJAA (ORCPT <rfc822;w@1wt.eu>);
        Fri, 26 Aug 2016 05:00:00 -0400
Received: from mout.kundenserver.de ([212.227.126.133]:52151 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752401AbcHZI76 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 Aug 2016 04:59:58 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, shawnguo@kernel.org,
        kernel@pengutronix.de, fabio.estevam@nxp.com, robh+dt@kernel.org,
        mark.rutland@arm.com, linux@armlinux.org.uk
Subject: Re: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D
Date: Fri, 26 Aug 2016 10:59:11 +0200
Message-ID: <3283479.PKRDjkX0Md@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1472209971-32469-4-git-send-email-Anson.Huang@nxp.com>
References: <1472209971-32469-1-git-send-email-Anson.Huang@nxp.com> <1472209971-32469-4-git-send-email-Anson.Huang@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:/7kSybv2XqCyYr45Fd0Al8grPVtAAy3+qOCDV9vfWHufeZQonLq
 CzJqfkHqq5uvnVa6Nfm+Rq7r/0fYjZRIrEERAChrP/XeyvBxoAE5mi/wEVFwWQbVYpcqg6n
 u3eqR73R4xWCjDABUPa7u5Dprl0XSmvdG7jNWgJxuY/Aue6p0O1dUiAhWcJJOu7jKrhfXoW
 jjpV5L45LmWgUNRH+u49w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:U/E44hfQt7U=:JnD1OL0+zoh8d+2IBWpLPK
 FM6tLbkSaywNUnfLCMUSP2EG7jjHzwd1R2x+iPpWmh7F4NbZE0kh+EYjYYY8TzKwcu5JjVtBf
 B1S6S3Di7IZlJ0Qx/POnERSKSNEy0/oIm0nPmVLPnyDY3UXGMuKRBuvG2+Br+HoXjlObj1DLd
 cmursJ2DaEtIv/lD2WMpNj8Efy1LH3rXUcPOK5E6S3QXxUbDlZ9HbTYg1lKnwWwO4Zbe0sV9K
 NcZkdlx049YuDUj8fqHNULxGGcEqAx2t8LeuEsrpr14UJamti7mN2OQ6KoLOfQ7sM+67g99dv
 RGoeWS75fG/qgHWDYYBkp4JBQR+Y+ndyzwDNWw2NdVpyXZAMXtV6eeR0R6HmiUOueO/0132WN
 dmUUhENbhh1brKF4h+YnL0A2hLWghlNrIeUzPKwSYo62Se3p0C97bAI9jv7MjtN8kgR0usMhq
 Z1E6FDGL44QZ1Di5r1y56ffynmxclX0ss12teLgmcPMFpPLg1wlmx0bv2JWTEx0sM1ndIQeoV
 OhmaBfFq3+A6sNda6nvtLCs7esRQuFcz6MRYYvwCs0Go8gIRzuB28RZtvXVWks44JUgKh4MM/
 tsAVWOy6v7wZh/zckwqp0IvyrDOPW+2OVwoJbaTa9l2LjXjm1nWVnF6FwTqk4PwigdzqlytiV
 i4YGmrsd+IWAPgeV9r67GUjemG2PEeQ3uUiuodj83zO3JMbZTSAi2//JdqEUez0Vnp49lIyOH
 0l49zEdbD8ug8/In
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, August 26, 2016 7:12:51 PM CEST Anson Huang wrote:
> i.MX7D has 2 cortex-a7 ARM core, add support for
> booting up SMP kernel with 2 CPUs.
> 
> The existing i.MX SMP code is designed for i.MX6
> series SoCs which have cortex-a9 ARM core, but i.MX7D
> has 2 cortex-a7 ARM core, so we need to add runtime
> check for those differences between cortex-a9 and
> cortex-a7.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 

Can't you just point i.MX7D to start from secondary_startup
rather than v7_secondary_startup?

 ENTRY(v7_secondary_startup)
+       .word   0xc070                  @ 0xc07 is cortex-a7 id
+       .word   0xfff0                  @ mask for core type
+

This looks like you are trying to execute instructions that are
actually data. Does this work?

On a side note, could you rename v7_secondary_startup to
imx6_secondary_startup? The name sounds overly generic
on a multiplatform kernel.

	Arnd