From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Wolfram Sang <wsa@the-dreams.de>, Vinod Koul <vinod.koul@intel.com>
Cc: Felipe Balbi <balbi@ti.com>,
linux-kernel@vger.kernel.org, subhransu.s.prusty@intel.com,
Alan Stern <stern@rowland.harvard.edu>,
Alexandre Courbot <acourbot@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Gross <agross@codeaurora.org>,
Baruch Siach <baruch@tkos.co.il>, Ben Skeggs <bskeggs@redhat.com>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
"Chew, Chiau Ee" <chiau.ee.chew@intel.com>,
Chris Ball <chris@printf.net>,
Dan Carpenter <dan.carpenter@oracle.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Dave Airlie <airlied@redhat.com>,
David Herrmann <dh.herrmann@gmail.com>,
dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, "Du,
Wenkai" <wenkai.du@intel.com>,
Grant Grundler <grundler@chromium.org>,
Ilia Mirkin <imirkin@alum.mit.edu>,
intel-gfx@lists.freedesktop.org,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Jani Nikula <jani.nikula@intel.com>,
Jingoo Han <jg1.han@samsung.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-nfc@ml01.01.org,
linux-omap@vger.kernel.org, linux-pm@vger.kernel.org,
linux-serial@vger.kernel.org, linux-spi@vger.kernel.org,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
Marcin Wojtas <mw@semihalf.com>,
Mika Westerberg <mika.westerberg@linux.jf.intel.com>,
patches@opensource.wolfsonmicro.com,
Pramod Gurav <pramod.gurav@smartplayin.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Rob Clark <robdclark@gmail.com>,
Romain Baeriswyl <Romain.Baeriswyl@abilis.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Seungwon Jeon <tgih.jun@samsung.com>,
Shinya Kuribayashi <skuribay@pobox.com>,
Thierry Reding <treding@nvidia.com>,
Tim Kryger <tim.kryger@linaro.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper
Date: Thu, 25 Sep 2014 21:54:36 +0200 [thread overview]
Message-ID: <32849712.0gtj7BlKY3@vostro.rjw.lan> (raw)
In-Reply-To: <20140925142758.GB1316@katana>
On Thursday, September 25, 2014 04:27:58 PM Wolfram Sang wrote:
>
> --Bn2rw/3z4jIqBvZU
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Thu, Sep 25, 2014 at 09:22:01AM -0500, Felipe Balbi wrote:
> > On Thu, Sep 25, 2014 at 01:27:18PM +0530, Vinod Koul wrote:
> > > On Wed, Sep 24, 2014 at 03:32:19PM -0500, Felipe Balbi wrote:
> > > > > > > OK, I guess this is as good as it gets.
> > > > > > >=20
> > > > > > > What tree would you like it go through?
> > > > > >=20
> > > > > > Do we really need this new helper ? I mean, the very moment when =
> we
> > > > > > decide to implement ->runtime_idle() we will need to get rid of t=
> his
> > > > > > change. I wonder if it's really valid...
> > > > >=20
> > > > > I'm not sure I'm following? This seems to simply implement what dr=
> ivers
> > > > > have been doing already as one function. Why would it be invalid t=
> o reduce
> > > > > code duplication?
> > > >=20
> > > > For two reasons:
> > > >=20
> > > > 1) the helper has no inteligence whatsoever. It just calls the same
> > > > functions.
> > > >=20
> > > > 2) the duplication will vanish whenever someone implements
> > > > ->runtime_idle() and have that call pm_runtime_autosuspend() (like PCI
> > > > and USB buses are doing today). This will just be yet another line th=
> at
> > > > needs to change.
> > > >=20
> > > > Frankly though, no strong feelings, I just think it's a commit that
> > > > doesn't bring that any benefits other than looking like one line was
> > > > removed.
> > > and yes that is what it tries to do nothing more nothing less. If in fu=
> ture
> > > there are no users (today we have quite a few), then we can remove the =
> dead
> > > macro, no harm. But that is not the situation today.
> >=20
> > as I said, a commit that's bound to be useless. It's not like you're
> > saving 10 lines of code, it's only one. Replacing two simple lines with
> > a function which takes <joke> almost as many characters to type </joke>.
> >=20
> > IMO, this is pretty useless and I'd rather not see them in the drivers I
> > maintain, sorry.
>
> It is not a NACK from me; yet from a high-level perspective I agree with
> Felipe.
OK
I'd rather not merge something that driver people don't want to use.
Vinod?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2014-09-25 19:34 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 16:14 [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper Vinod Koul
2014-09-24 16:14 ` [PATCH 01/27] PM: Add helper pm_runtime_last_busy_and_autosuspend() Vinod Koul
2014-09-24 17:54 ` Pavel Machek
2014-09-25 8:00 ` Vinod Koul
2014-09-25 8:13 ` Ulf Hansson
2014-09-24 16:14 ` [PATCH 02/27] dmaengine: ste_dma: use pm_runtime_last_busy_and_autosuspend helper Vinod Koul
2014-09-25 13:19 ` Linus Walleij
2014-09-24 16:14 ` [PATCH 03/27] extcon: arizona: " Vinod Koul
2014-09-25 1:05 ` Chanwoo Choi
2014-09-25 8:10 ` Charles Keepax
2014-09-24 16:14 ` [PATCH 04/27] drm/i915: " Vinod Koul
2014-09-24 18:35 ` Daniel Vetter
2014-09-24 16:14 ` [PATCH 05/27] drm/nouveau: " Vinod Koul
2014-09-24 16:14 ` [PATCH 06/27] drm/radeon: " Vinod Koul
2014-09-24 20:37 ` Alex Deucher
2014-09-24 16:14 ` [PATCH 07/27] vga_switcheroo: " Vinod Koul
2014-09-24 20:37 ` Alex Deucher
2014-09-24 16:14 ` [PATCH 08/27] i2c: designware: " Vinod Koul
2014-09-24 16:14 ` [PATCH 09/27] i2c: omap: " Vinod Koul
2014-09-24 16:15 ` [PATCH 10/27] i2c: qup: " Vinod Koul
2014-09-24 16:15 ` [PATCH 11/27] mfd: ab8500-gpadc: " Vinod Koul
2014-09-26 8:38 ` Linus Walleij
2014-10-06 21:40 ` Lee Jones
2014-10-07 7:21 ` Lee Jones
2014-10-07 7:38 ` Vinod Koul
2014-09-24 16:15 ` [PATCH 12/27] mfd: arizona: " Vinod Koul
2014-09-25 8:10 ` Charles Keepax
2014-10-06 21:41 ` Lee Jones
2014-10-07 7:21 ` Lee Jones
2014-09-24 16:15 ` [PATCH 13/27] mei: " Vinod Koul
2014-09-24 16:15 ` [PATCH 14/27] mmc: " Vinod Koul
2014-09-24 16:15 ` [PATCH 15/27] mmc: mmci: " Vinod Koul
2014-09-24 16:15 ` [PATCH 16/27] mmc: omap_hsmmc: " Vinod Koul
2014-09-24 16:15 ` [PATCH 17/27] mmc: sdhci-pxav3: " Vinod Koul
2014-09-24 16:15 ` [PATCH 18/27] mmc: sdhci: " Vinod Koul
2014-09-24 16:15 ` [PATCH 19/27] NFC: trf7970a: " Vinod Koul
2014-09-24 16:15 ` [PATCH 20/27] pm2301-charger: " Vinod Koul
2014-09-24 16:15 ` [PATCH 21/27] spi: omap2-mcspi: " Vinod Koul
2014-09-24 16:58 ` Mark Brown
2014-09-24 16:39 ` Vinod Koul
2014-09-25 13:03 ` Mark Brown
2014-09-24 16:15 ` [PATCH 22/27] spi: orion: " Vinod Koul
2014-09-25 13:03 ` Mark Brown
2014-09-24 16:15 ` [PATCH 23/27] spi: ti-qspi: " Vinod Koul
2014-09-25 13:04 ` Mark Brown
2014-09-24 16:15 ` [PATCH 24/27] spi: core: " Vinod Koul
2014-09-25 13:04 ` Mark Brown
2014-09-24 16:15 ` [PATCH 25/27] tty: serial: omap: " Vinod Koul
2014-09-24 16:15 ` [PATCH 26/27] usb: musb: omap2430: " Vinod Koul
2014-09-24 16:15 ` [PATCH 27/27] video: fbdev: " Vinod Koul
2014-09-24 20:28 ` [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper Rafael J. Wysocki
2014-09-25 7:46 ` Vinod Koul
[not found] ` <20140925142201.GD28045@saruman>
[not found] ` <20140925142758.GB1316@katana>
2014-09-25 19:54 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32849712.0gtj7BlKY3@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=Romain.Baeriswyl@abilis.com \
--cc=acourbot@nvidia.com \
--cc=agross@codeaurora.org \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=balbi@ti.com \
--cc=baruch@tkos.co.il \
--cc=bjorn.andersson@sonymobile.com \
--cc=bskeggs@redhat.com \
--cc=chiau.ee.chew@intel.com \
--cc=chris@printf.net \
--cc=dan.carpenter@oracle.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dh.herrmann@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=grundler@chromium.org \
--cc=iivanov@mm-sol.com \
--cc=imirkin@alum.mit.edu \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jg1.han@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nfc@ml01.01.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mika.westerberg@linux.jf.intel.com \
--cc=mw@semihalf.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pramod.gurav@smartplayin.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robdclark@gmail.com \
--cc=skuribay@pobox.com \
--cc=stern@rowland.harvard.edu \
--cc=subhransu.s.prusty@intel.com \
--cc=tgih.jun@samsung.com \
--cc=tim.kryger@linaro.org \
--cc=tomi.valkeinen@ti.com \
--cc=treding@nvidia.com \
--cc=ulf.hansson@linaro.org \
--cc=vinod.koul@intel.com \
--cc=wenkai.du@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).