From: Marcel Holtmann <marcel@holtmann.org>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavan Savoy <pavan_savoy@ti.com>, Arnd Bergmann <arnd@arndb.de>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
linux-media@vger.kernel.org,
linux-wireless <linux-wireless@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status
Date: Wed, 13 Jul 2016 11:56:02 +0100 [thread overview]
Message-ID: <32897348-2AC5-4AB7-BF58-B1E36FC19CF2@holtmann.org> (raw)
In-Reply-To: <20160713074114.76c35d04@recife.lan>
Hi Mauro,
>> On mips and parisc:
>>
>> drivers/bluetooth/btwilink.c: In function 'ti_st_open':
>> drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit constant conversion [-Woverflow]
>> hst->reg_status = -EINPROGRESS;
>>
>> drivers/nfc/nfcwilink.c: In function 'nfcwilink_open':
>> drivers/nfc/nfcwilink.c:396:31: warning: overflow in implicit constant conversion [-Woverflow]
>> drv->st_register_cb_status = -EINPROGRESS;
>>
>> There are actually two issues:
>> 1. Whether "char" is signed or unsigned depends on the architecture.
>> As the completion callback data is used to pass a (negative) error
>> code, it should always be signed.
>> 2. EINPROGRESS is 150 on mips, 245 on parisc.
>> Hence -EINPROGRESS doesn't fit in a signed 8-bit number.
>>
>> Change the callback status from "char" to "int" to fix these.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Patch looks sane to me, but who will apply it?
>
> Anyway:
>
> Acked-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
I can take it through bluetooth-next if there is no objection.
Samuel, are you fine with that?
Regards
Marcel
next prev parent reply other threads:[~2016-07-13 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 9:02 [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status Geert Uytterhoeven
2016-07-13 10:41 ` Mauro Carvalho Chehab
2016-07-13 10:56 ` Marcel Holtmann [this message]
2016-07-13 11:00 ` Samuel Ortiz
2016-07-13 13:12 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32897348-2AC5-4AB7-BF58-B1E36FC19CF2@holtmann.org \
--to=marcel@holtmann.org \
--cc=aloisio.almeida@openbossa.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=pavan_savoy@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).