From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AB3CC433EF for ; Fri, 24 Jun 2022 15:24:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232214AbiFXPYC (ORCPT ); Fri, 24 Jun 2022 11:24:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232245AbiFXPXw (ORCPT ); Fri, 24 Jun 2022 11:23:52 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45D1A4ECDE for ; Fri, 24 Jun 2022 08:23:51 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id i10so3650068wrc.0 for ; Fri, 24 Jun 2022 08:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=+bhqNUnBw2VlBb+vKh9BVjK86IEzMRn9rbxeRT0RpzU=; b=unSq8mf41jKUNz0zl0xeXhApqvYec4N3cTR8n5fovaRhwmji9yx7zuESRXHRXiIgtb kbkB9TDS6IQFZtFmjwOYK6SS2XmBHK/SGChPmng3OZGRqr5o1Eu9OYieOjdRmwYRldOe XptsV14p+JHshQP7F3oBh05e6GPreOfhXUpnqAhQo3yOMHWQu4Dsp829OUV1a++xItDc B94B+a2nf0H6T4gUUrBefrDJ7RzZMxETNjhcir5Re9++JIz88YRFgFl0mT/DPRzQGicO 5KnUPkgJzqnO8mEm/Fj8vH/JPd93G6DAnle4x0/9ZrC4deqywXDK/DASo9VEp43Ot8FZ mu8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+bhqNUnBw2VlBb+vKh9BVjK86IEzMRn9rbxeRT0RpzU=; b=DLh1/8ZWAyRxqXx5cLVI0q4vtWnrtO58ubmuM0i4ATxEh9R8TfBvuBWksx42pRMQRL bqqFeeXQwRv2mqdoBdBZANfwOnD853+T7tUCTEfNIS1Di7MJHvWB0iwvCvSrPTrGzV78 o4jIzTSNTcgQVT7laHiY7oy6LBG49qO/U/m4GkX3pC/S65KIZjX/beYgwGo0sCET1fSs oCJkYRhvC65lnABP60UOs6B3pvFCoxvhnCnBfghR+qpACJhVnfhHYWk2kJdEz049LjS5 kbzNEM82X7D8tjCEtn49mh8W7KlRenTZl3JBGmt1qheVuWjhtnzDNgv3dZSEPOs4RtPy P0IA== X-Gm-Message-State: AJIora8zFJ9d86kxRwKjK6zG70szA2AxhuCcff9m/tHvrwWx1FC8HmOP dlSQF84ZzzsaT1IuAQQLWGQkYQ== X-Google-Smtp-Source: AGRyM1s9YBvmKfcs61SMXYZ8cH6Yai5Wzlk65zklCRkC8/sqfy96FjnpPWRBJJj5I7pxa5IPeTokBw== X-Received: by 2002:adf:df8a:0:b0:21b:9219:634c with SMTP id z10-20020adfdf8a000000b0021b9219634cmr13427248wrl.669.1656084229815; Fri, 24 Jun 2022 08:23:49 -0700 (PDT) Received: from [192.168.0.237] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id k31-20020a05600c1c9f00b0039c5642e430sm3309268wms.20.2022.06.24.08.23.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 08:23:49 -0700 (PDT) Message-ID: <329101e6-4f81-78c3-818b-8d70905248a6@linaro.org> Date: Fri, 24 Jun 2022 17:23:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v1 3/3] arm64: dts: qcom: sc7280: Add missing pcie clocks Content-Language: en-US To: Krishna chaitanya chundru , helgaas@kernel.org Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_hemantk@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_ramkri@quicinc.com, manivannan.sadhasivam@linaro.org, swboyd@chromium.org, dmitry.baryshkov@linaro.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <1656062391-14567-1-git-send-email-quic_krichai@quicinc.com> <1656062391-14567-4-git-send-email-quic_krichai@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1656062391-14567-4-git-send-email-quic_krichai@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/06/2022 11:19, Krishna chaitanya chundru wrote: > Add missing pcie clocks. > > Signed-off-by: Krishna chaitanya chundru > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > Thank you for your patch. There is something to discuss/improve. > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index e66fc67..a5ce095 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -2043,6 +2043,8 @@ > <&gcc GCC_PCIE_1_SLV_AXI_CLK>, > <&gcc GCC_PCIE_1_SLV_Q2A_AXI_CLK>, > <&gcc GCC_AGGRE_NOC_PCIE_TBU_CLK>, > + <&gcc GCC_AGGRE_NOC_PCIE_CENTER_SF_AXI_CLK>, > + <&gcc GCC_AGGRE_NOC_PCIE_1_AXI_CLK>, > <&gcc GCC_DDRSS_PCIE_SF_CLK>; > > clock-names = "pipe", > @@ -2055,6 +2057,8 @@ > "bus_slave", > "slave_q2a", > "tbu", > + "aggre0", > + "aggre1", > "ddrss_sf_tbu"; Unfortunately wrong order. Please test your patches with `make dtbs_check`. Best regards, Krzysztof