From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752077AbcFCHjp (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Jun 2016 03:39:45 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:51368 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751348AbcFCHjo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Jun 2016 03:39:44 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, linux-rpi-kernel@lists.infradead.org,
        Eric Anholt <eric@anholt.net>, Will Deacon <will.deacon@arm.com>,
        open list <linux-kernel@vger.kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v2 5/9] arm64: Add BCM2835 support to the defconfig.
Date: Fri, 03 Jun 2016 09:36:03 +0200
Message-ID: <3299125.qWct7BqQgQ@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1464934708-24769-6-git-send-email-kraxel@redhat.com>
References: <1464934708-24769-1-git-send-email-kraxel@redhat.com> <1464934708-24769-6-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:wjYVJk59F+FJz01mbX2ISVMHLEaIGkFtoRzG5q6ED9nosUEvypz
 0wzNyhvERjH2Wfd0E9GLdbR3g+23VUYy/yOBDTEJb/lYRhr6j4j9EInCKX1Mo3sB/CyH2ie
 iKtt1avcKgDK/iCjEj88ydoHLbj0MWo3HD7WBRCTJyTrSCz2RI2uFQzcNZlhNTGx+0p3VJ9
 EojhWGkSvSGZCkoLzwsUw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:uIKGVtS7Kh0=:e9le/JI2nWQJalcE5RzAm4
 4pE2tB2u5hkXzQvE43JZDMTGkCqFj19zKDTL55RvdFUR9w2820REsvXeeHp/RCWA0Z2cdJtix
 69S0VO3WOPbIpkr+MAVmpyhDHi3/ngZaAqpgryJXzRQmlMAQ3hNQBlGg+SENPmTM6XcavH2Yd
 izVOz2RtZhonmNYeRNkwfZM0/EtECKV4xmykP88QUHGkYSoXOjWBeceFVTPXMQSoWYGsUOA1e
 UJPhXam2r9gokChvSbBLTNU1zWZohEnEsdBYQCNJpgii7VjIZ9C+Ew2Fs+E/dAhqPVx5F8IrM
 o5ZGpKlzxHMrlUYLdOcoEYAwp2FAIHTH5vpfo4TPOKsVirqJvEWzVhGN4rKMUtLk4Qqd3qwOR
 ix8aFdRrGWu8F+6O2huPwK4ISOFxzgY7lG9RpJkpUiD//+CIenOaH3ovaPAZlX4WTO12pb6Io
 2twRsb0/D+XZJJZt/7YOgjglwtpfRM7+oofhPi+QtKQExp1cb57Y7c4qc+U3BnNNJhpmFDCLi
 79898RcoL5gICSwJRLEl9VusZM4t+/bR+nm+5Xwa9fnHDV998aUDEWm3CzdTCQpPlDKpS4//S
 Am6f99sUNq5jobLt/OL6NLKHY9iLYOduy7Ioo+1akPnGkKZE/Z3UeCLK002cRb7k5unpYxOug
 /enFGhh+fOAnJdh7sf5lSaVWgYkqmoGOa3wsG39Fb77jPw7h4fMREu90VdXK9X6Kaum1NlCfO
 zA/nm9EkYJyg91IP
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, June 3, 2016 8:18:24 AM CEST Gerd Hoffmann wrote:
> From: Eric Anholt <eric@anholt.net>
> 
> Made with make defconfig; make menuconfig (only saying Y to new
> entries); make savedefconfig.

Please try not to mix 'make savedefconfig' changes with your
own changes, it make it harder to review and can lead to more
conflicts.

> @@ -140,6 +141,9 @@ CONFIG_USB_NET_PLUSB=m
>  CONFIG_USB_NET_MCS7830=m
>  CONFIG_WL18XX=m
>  CONFIG_WLCORE_SDIO=m
> +CONFIG_USB_USBNET=y
> +CONFIG_USB_NET_SMSC95XX=y
> +# CONFIG_WLAN is not set
>  CONFIG_INPUT_EVDEV=y
>  CONFIG_KEYBOARD_GPIO=y

Can this be =m like the others?

> -CONFIG_FB=y
> -CONFIG_FRAMEBUFFER_CONSOLE=y

Is this intended?

> +CONFIG_DRM=y
> +CONFIG_DRM_VC4=y
>  CONFIG_FB_ARMCLCD=y
>  CONFIG_LOGO=y

Maybe modules?


>  # CONFIG_LOGO_LINUX_MONO is not set
>  # CONFIG_LOGO_LINUX_VGA16 is not set
>  CONFIG_SOUND=y
>  CONFIG_SND=y
>  CONFIG_SND_SOC=y
> +CONFIG_SND_BCM2835_SOC_I2S=y
>  CONFIG_SND_SOC_RCAR=y
>  CONFIG_SND_SOC_AK4613=y
>  CONFIG_USB=y

We probably want CONFIG_SND=m, but that should be a separate patch.

> @@ -270,6 +284,7 @@ CONFIG_RTC_DRV_SUN6I=y
>  CONFIG_RTC_DRV_XGENE=y
>  CONFIG_DMADEVICES=y
>  CONFIG_PL330_DMA=y
> +CONFIG_DMA_BCM2835=y
>  CONFIG_TEGRA20_APB_DMA=y
>  CONFIG_QCOM_BAM_DMA=y
>  CONFIG_RCAR_DMAC=y

Does any essential driver depend on this one?

> @@ -311,7 +329,6 @@ CONFIG_AUTOFS4_FS=y
>  CONFIG_FUSE_FS=y
>  CONFIG_CUSE=y
>  CONFIG_VFAT_FS=y
> -CONFIG_TMPFS=y
>  CONFIG_HUGETLBFS=y
>  CONFIG_CONFIGFS_FS=y
>  CONFIG_EFIVAR_FS=y

Why?

	Arnd