From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D38FC77B7A for ; Fri, 2 Jun 2023 20:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236091AbjFBUDx (ORCPT ); Fri, 2 Jun 2023 16:03:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235459AbjFBUDu (ORCPT ); Fri, 2 Jun 2023 16:03:50 -0400 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 520939D; Fri, 2 Jun 2023 13:03:48 -0700 (PDT) Received: from [192.168.1.103] (31.173.82.21) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Fri, 2 Jun 2023 23:03:39 +0300 Subject: Re: [PATCH v1 26/43] pata: cirrus: add DT support for Cirrus EP93xx To: Nikita Shubin , Alexander Sverdlin , Arnd Bergmann , Linus Walleij , Damien Le Moal CC: Michael Peters , Kris Bahnsen , , References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230601054549.10843-8-nikita.shubin@maquefel.me> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <32a041b0-d02d-4353-4794-094b96271e3a@omp.ru> Date: Fri, 2 Jun 2023 23:03:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20230601054549.10843-8-nikita.shubin@maquefel.me> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [31.173.82.21] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 06/02/2023 19:42:21 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 177822 [Jun 02 2023] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 515 515 1b17fc6ab778ab3730d780f30d802773a7d822ac X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_no_received} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.82.21 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.82.21 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1;31.173.82.21:7.1.2;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.82.21 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 06/02/2023 19:47:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 6/2/2023 6:52:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 6/1/23 8:45 AM, Nikita Shubin wrote: > - find register range from the device tree > - get interrupts from device tree Hm... I'm not seeing such changes in your patch? > Signed-off-by: Nikita Shubin > --- > > Notes: > v0 -> v1: > > - fixed headers > - dropped coma in id table > > drivers/ata/pata_ep93xx.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c > index c6e043e05d43..8d363bc71342 100644 > --- a/drivers/ata/pata_ep93xx.c > +++ b/drivers/ata/pata_ep93xx.c > @@ -40,6 +40,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1016,9 +1017,16 @@ static int ep93xx_pata_remove(struct platform_device *pdev) > return 0; > } > > +static const struct of_device_id ep93xx_pata_of_ids[] = { > + { .compatible = "cirrus,ep9312-pata" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, ep93xx_pata_of_ids); > + > static struct platform_driver ep93xx_pata_platform_driver = { > .driver = { > .name = DRV_NAME, > + .of_match_table = ep93xx_pata_of_ids, > }, > .probe = ep93xx_pata_probe, > .remove = ep93xx_pata_remove, MBR, Sergey