From: Philipp Zabel <p.zabel@pengutronix.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Vivek Gautam <vivek.gautam@codeaurora.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] reset: Fix {of,devm}_reset_control_array_get kerneldoc return types
Date: Wed, 20 Nov 2019 15:43:48 +0100 [thread overview]
Message-ID: <32ae1093cfee84676e99336a2e5842758a756bb1.camel@pengutronix.de> (raw)
In-Reply-To: <20191120142614.29180-3-geert+renesas@glider.be>
On Wed, 2019-11-20 at 15:26 +0100, Geert Uytterhoeven wrote:
> of_reset_control_array_get() and devm_reset_control_array_get() return
> struct reset_control pointers, not internal struct reset_control_array
> pointers, just like all other reset control API calls.
>
> Correct the kerneldoc to match the code.
>
> Fixes: 17c82e206d2a3cd8 ("reset: Add APIs to manage array of resets")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/reset/core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 55245f485b3819da..4ea62aa00260f82c 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -861,8 +861,7 @@ static int of_reset_control_get_count(struct device_node *node)
> * @acquired: only one reset control may be acquired for a given controller
> * and ID
> *
> - * Returns pointer to allocated reset_control_array on success or
> - * error on failure
> + * Returns pointer to allocated reset_control on success or error on failure
> */
> struct reset_control *
> of_reset_control_array_get(struct device_node *np, bool shared, bool optional,
> @@ -915,8 +914,7 @@ EXPORT_SYMBOL_GPL(of_reset_control_array_get);
> * that just have to be asserted or deasserted, without any
> * requirements on the order.
> *
> - * Returns pointer to allocated reset_control_array on success or
> - * error on failure
> + * Returns pointer to allocated reset_control on success or error on failure
> */
> struct reset_control *
> devm_reset_control_array_get(struct device *dev, bool shared, bool optional)
Thank you, applied to reset/fixes.
regards
Philipp
next prev parent reply other threads:[~2019-11-20 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 14:26 [PATCH 0/3] reset: Miscellaneous improvements Geert Uytterhoeven
2019-11-20 14:26 ` [PATCH 1/3] reset: Do not register resource data for missing resets Geert Uytterhoeven
2019-11-20 14:43 ` Philipp Zabel
2019-11-20 14:45 ` Geert Uytterhoeven
2019-11-20 14:26 ` [PATCH 2/3] reset: Fix {of,devm}_reset_control_array_get kerneldoc return types Geert Uytterhoeven
2019-11-20 14:43 ` Philipp Zabel [this message]
2019-11-20 14:26 ` [PATCH 3/3] reset: Align logic and flow in managed helpers Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32ae1093cfee84676e99336a2e5842758a756bb1.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).