From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161121AbcFQG3A (ORCPT ); Fri, 17 Jun 2016 02:29:00 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:36467 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754824AbcFQG25 (ORCPT ); Fri, 17 Jun 2016 02:28:57 -0400 Reply-To: chris@lapa.com.au Subject: Re: [PATCH v3 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm. References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1466139626-51434-1-git-send-email-chris@lapa.com.au> <1466139626-51434-4-git-send-email-chris@lapa.com.au> <57639832.6000201@samsung.com> To: Krzysztof Kozlowski , dwmw2@infradead.org, dbaryshkov@gmail.com, sre@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Chris Lapa Message-ID: <32bde516-87b5-bb63-c6a3-1ec043758904@lapa.com.au> Date: Fri, 17 Jun 2016 16:28:50 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <57639832.6000201@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/06/2016 4:26 PM, Krzysztof Kozlowski wrote: > On 06/17/2016 07:00 AM, Chris Lapa wrote: >> From: Chris Lapa >> >> The max8903_charger.h file indicated that dcm and dok were not optional >> when dc_valid is set. >> >> It makes sense to have dok as a compulsory pin when dc_valid is given. >> However dcm can be optionally wired to a fixed level especially when the >> circuit is configured for dc power exclusively. >> >> The previous implementation already allowed for this somewhat, however no >> error was given if dok wasn't given whilst dc_valid was. >> >> The new implementation enforces dok presence when dc_valid is given. Whilst >> allowing dcm to be optional. >> >> Signed-off-by: Chris Lapa >> --- >> drivers/power/max8903_charger.c | 23 ++++++++++------------- >> include/linux/power/max8903_charger.h | 6 +++--- >> 2 files changed, 13 insertions(+), 16 deletions(-) >> >> diff --git a/drivers/power/max8903_charger.c b/drivers/power/max8903_charger.c >> index 0a5b0e1..dbd911c4 100644 >> --- a/drivers/power/max8903_charger.c >> +++ b/drivers/power/max8903_charger.c >> @@ -211,27 +211,24 @@ static int max8903_probe(struct platform_device *pdev) >> } >> >> if (pdata->dc_valid) { >> - if (pdata->dok && gpio_is_valid(pdata->dok) && >> - pdata->dcm && gpio_is_valid(pdata->dcm)) { >> + if (pdata->dok && gpio_is_valid(pdata->dok)) { >> gpio = pdata->dok; /* PULL_UPed Interrupt */ >> ta_in = gpio_get_value(gpio) ? 0 : 1; >> + } else { >> + dev_err(dev, "When DC is wired, DOK should" >> + " be wired as well.\n"); > > Just found one nit. Don't split the strings. > dev_err(dev, > "When DC is wired, DOK should be wired as well.\n"); I saw that one as well when I ran checkpatch, however I thought if I changed it then I would get a warning about the line being > 80 chars. So wasn't sure which direction to go. Thanks Chris > > Best regards, > Krzysztof >