Re: [PATCH v4 09/14] vhost/vdpa: use get_config_size callback in vhost_vdpa_config_validate()

From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>,
	virtualization@lists.linux-foundation.org
Cc: netdev@vger.kernel.org, Xie Yongji <xieyongji@bytedance.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	linux-kernel@vger.kernel.org, Max Gurtovoy <mgurtovoy@nvidia.com>,
	Parav Pandit <parav@nvidia.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH v4 09/14] vhost/vdpa: use get_config_size callback in vhost_vdpa_config_validate()
Date: Thu, 18 Mar 2021 11:22:22 +0800	[thread overview]
Message-ID: <32d55226-445e-4de5-2f5e-327bc724f0c4@redhat.com> (raw)
In-Reply-To: <20210315163450.254396-10-sgarzare@redhat.com>


在 2021/3/16 上午12:34, Stefano Garzarella 写道:
> Let's use the new 'get_config_size()' callback available instead of
> using the 'virtio_id' to get the size of the device config space.
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>


Acked-by: Jason Wang <jasowang@redhat.com>


> ---
>   drivers/vhost/vdpa.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index e0a27e336293..7ae4080e57d8 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -188,13 +188,8 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp)
>   static int vhost_vdpa_config_validate(struct vhost_vdpa *v,
>   				      struct vhost_vdpa_config *c)
>   {
> -	long size = 0;
> -
> -	switch (v->virtio_id) {
> -	case VIRTIO_ID_NET:
> -		size = sizeof(struct virtio_net_config);
> -		break;
> -	}
> +	struct vdpa_device *vdpa = v->vdpa;
> +	long size = vdpa->config->get_config_size(vdpa);
>   
>   	if (c->len == 0)
>   		return -EINVAL;