From: Paolo Bonzini <pbonzini@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>
Cc: Maxim Levitsky <mlevitsk@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Kevin Wolf <kwolf@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: Commit 'iomap: add support for dma aligned direct-io' causes qemu/KVM boot failures
Date: Thu, 29 Sep 2022 19:35:43 +0200 [thread overview]
Message-ID: <32db4f89-a83f-aac4-5d27-0801bdca60bf@redhat.com> (raw)
In-Reply-To: <20220929163931.GA10232@lst.de>
On 9/29/22 18:39, Christoph Hellwig wrote:
> On Thu, Sep 29, 2022 at 10:37:22AM -0600, Keith Busch wrote:
>>> I am aware, and I've submitted the fix to qemu here:
>>>
>>> https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00398.html
>>
>> I don't think so. Memory alignment and length granularity are two completely
>> different concepts. If anything, the kernel's ABI had been that the length
>> requirement was also required for the memory alignment, not the other way
>> around. That usage will continue working with this kernel patch.
>
> Well, Linus does treat anything that breaks significant userspace
> as a regression. Qemu certainly is significant, but that might depend
> on bit how common configurations hitting this issue are.
Seeing the QEMU patch, I agree that it's a QEMU bug though. I'm
surprised it has ever worked.
It requires 4K sectors in the host but not in the guest, and can be
worked around (if not migrating) by disabling O_DIRECT. I think it's
not that awful, but we probably should do some extra releases of QEMU
stable branches.
Paolo
next prev parent reply other threads:[~2022-09-29 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 15:41 Commit 'iomap: add support for dma aligned direct-io' causes qemu/KVM boot failures Maxim Levitsky
2022-09-29 15:48 ` Keith Busch
2022-09-29 16:16 ` Maxim Levitsky
2022-09-29 16:37 ` Keith Busch
2022-09-29 16:39 ` Christoph Hellwig
2022-09-29 17:35 ` Paolo Bonzini [this message]
2022-10-02 8:59 ` Maxim Levitsky
2022-10-02 13:56 ` Keith Busch
2022-10-03 7:06 ` Maxim Levitsky
2022-09-30 11:52 ` Thorsten Leemhuis
2022-11-04 11:59 ` Commit 'iomap: add support for dma aligned direct-io' causes qemu/KVM boot failures #forregzbot Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32db4f89-a83f-aac4-5d27-0801bdca60bf@redhat.com \
--to=pbonzini@redhat.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mlevitsk@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).