From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754389AbcHVKwd (ORCPT ); Mon, 22 Aug 2016 06:52:33 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:39409 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbcHVKwc (ORCPT ); Mon, 22 Aug 2016 06:52:32 -0400 Subject: Re: [RFC PATCH v2 1/2] mm/hugetlb: Introduce ARCH_HAS_GIGANTIC_PAGE To: Michal Hocko References: <1471834603-27053-1-git-send-email-xieyisheng1@huawei.com> <1471834603-27053-2-git-send-email-xieyisheng1@huawei.com> <20160822080101.GE13596@dhcp22.suse.cz> CC: , , , , , , , , , , , , From: Yisheng Xie Message-ID: <32ed1cea-df4b-a170-2d6f-0a4e05ee8405@huawei.com> Date: Mon, 22 Aug 2016 18:37:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160822080101.GE13596@dhcp22.suse.cz> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.32.149] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.57BAD893.00B6,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 6ac7c88655ceec9f6d3940a020e4ab24 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/8/22 16:01, Michal Hocko wrote: > On Mon 22-08-16 10:56:42, Xie Yisheng wrote: >> >> +config ARCH_HAS_GIGANTIC_PAGE >> + depends on HUGETLB_PAGE >> + bool >> + > > but is this really necessary? The code where we use > ARCH_HAS_GIGANTIC_PAGE already depends on HUGETLB_PAGE. > Hi Michal, Thank you for your reply. That right, it's no need to depends on HUGETLB_PAGE here. I will send v3 soon. Thanks Xie Yisheng > Other than that looks good to me and a nice simplification. > >> source "fs/configfs/Kconfig" >> source "fs/efivarfs/Kconfig" >> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index 87e11d8..8488dcc 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -1022,7 +1022,7 @@ static int hstate_next_node_to_free(struct hstate *h, nodemask_t *nodes_allowed) >> ((node = hstate_next_node_to_free(hs, mask)) || 1); \ >> nr_nodes--) >> >> -#if (defined(CONFIG_X86_64) || defined(CONFIG_S390)) && \ >> +#if defined(CONFIG_ARCH_HAS_GIGANTIC_PAGE) && \ >> ((defined(CONFIG_MEMORY_ISOLATION) && defined(CONFIG_COMPACTION)) || \ >> defined(CONFIG_CMA)) >> static void destroy_compound_gigantic_page(struct page *page, >> -- >> 1.7.12.4 >