From: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
To: Nadav Amit <namit@vmware.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
David Hildenbrand <david@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"kernel@openvz.org" <kernel@openvz.org>,
Wei Liu <wei.liu@kernel.org>,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Pv-drivers <Pv-drivers@vmware.com>
Subject: Re: [PATCH v1 2/2] Drivers: virtio: balloon: Report inflated memory
Date: Tue, 16 Aug 2022 10:50:07 +0300 [thread overview]
Message-ID: <32f11326-4c20-56f9-3537-a8099cc3cc46@virtuozzo.com> (raw)
In-Reply-To: <F230BF95-0EA2-4A12-A21A-E967E07589FF@vmware.com>
On 15.08.22 19:05, Nadav Amit wrote:
> On Aug 15, 2022, at 5:52 AM, Alexander Atanasov <alexander.atanasov@virtuozzo.com> wrote:
>
>> If it is going to be a place for generic logic may be it should be
>> renamed to balloon_common.[ch] ?
>>
>>> as possible. I made the effort to reuse this infrastructure (which is now
>>> used by both VMware and virtio), and would prefer to share as much code as
>>> possible.
>>>
>>> For instance, I would appreciate if the update upon inflate would go into
>>> balloon_page_list_enqueue() and balloon_page_enqueue(). VMware's 2MB pages
>>> logic is not shared, so it would require a change that is specific for
>>> VMware code.
>>
>> I looked at the code and i do not see how i can reuse it since
>> BALLOON_COMPACTION can be disabled and as you say even for VMWare it
>> would require updates on other places. Looks like if i do so i would
>> have to handle update from each driver for both cases. I think it is
>> better to clearly mark the spots when drivers do their internal
>> recalculations and report to the core. I see only VMWare is using
>> balloon_page_list_enqueue , virtio balloon is using only migration and
>> i don't see how to hook it there - i haven't checked the rest of the
>> balloons but i guess it would be similiar . I agree it is a good to have
>> a common place for such logic but it might be better of for a separate
>> work in the future.
>
> Fine. I would live with whatever you do and if needed change it later.
- balloon_page_list_enqueue and balloon_page_enqueue are called under locks.
- they work page by page
- different page sizes different hypervisors
- pages to bytes conversion again different page sizes
I will put the new code in balloon_common but i can not reuse what you
propose for the reasons above.
--
Regards,
Alexander Atanasov
next prev parent reply other threads:[~2022-08-16 9:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 8:36 [PATCH v4 1/1] Create debugfs file with virtio balloon usage information Alexander Atanasov
2022-07-05 8:59 ` Michael S. Tsirkin
2022-07-05 9:01 ` Alexander Atanasov
2022-08-09 10:35 ` Michael S. Tsirkin
2022-08-09 13:33 ` Alexander Atanasov
2022-07-13 16:25 ` Alexander Atanasov
2022-07-14 11:35 ` David Hildenbrand
2022-07-14 13:20 ` Alexander Atanasov
2022-07-14 13:24 ` David Hildenbrand
2022-07-14 13:35 ` Alexander Atanasov
2022-07-14 13:20 ` [PATCH v5 " Alexander Atanasov
2022-07-18 11:35 ` David Hildenbrand
2022-07-25 11:27 ` Alexander Atanasov
2022-07-25 11:36 ` David Hildenbrand
2022-07-26 14:08 ` [PATCH v6 1/2] " Alexander Atanasov
2022-07-26 14:10 ` [PATCH v6 2/2] Unify how inflated memory is accounted in virtio balloon driver Alexander Atanasov
2022-08-01 15:13 ` David Hildenbrand
2022-08-09 10:42 ` Michael S. Tsirkin
2022-08-01 15:18 ` [PATCH v6 1/2] Create debugfs file with virtio balloon usage information David Hildenbrand
2022-08-01 16:34 ` Alexander Atanasov
2022-08-01 20:12 ` David Hildenbrand
2022-08-02 8:53 ` [RFC] how the ballooned memory should be accounted by the drivers inside the guests? (was:[PATCH v6 1/2] Create debugfs file with virtio balloon usage information) Alexander Atanasov
2022-08-02 13:48 ` David Hildenbrand
2022-08-09 9:36 ` Alexander Atanasov
2022-08-09 9:49 ` [PATCH v1 1/2] Enable balloon drivers to report inflated memory Alexander Atanasov
2022-08-09 9:53 ` [PATCH v1 2/2] Drivers: virtio: balloon: Report " Alexander Atanasov
2022-08-09 17:44 ` Nadav Amit
2022-08-15 12:52 ` Alexander Atanasov
2022-08-15 16:05 ` Nadav Amit
2022-08-16 7:50 ` Alexander Atanasov [this message]
2022-08-09 10:32 ` [PATCH v1 1/2] Enable balloon drivers to report " Michael S. Tsirkin
2022-08-10 5:54 ` Alexander Atanasov
2022-08-10 6:05 ` Michael S. Tsirkin
2022-08-10 7:50 ` Alexander Atanasov
2022-08-10 9:16 ` Michael S. Tsirkin
2022-08-10 3:05 ` Muchun Song
2022-08-10 5:14 ` Alexander Atanasov
2022-08-09 10:03 ` [RFC] how the ballooned memory should be accounted by the drivers inside the guests? (was:[PATCH v6 1/2] Create debugfs file with virtio balloon usage information) David Hildenbrand
2022-08-09 10:44 ` [PATCH v6 1/2] Create debugfs file with virtio balloon usage information Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32f11326-4c20-56f9-3537-a8099cc3cc46@virtuozzo.com \
--to=alexander.atanasov@virtuozzo.com \
--cc=Pv-drivers@vmware.com \
--cc=david@redhat.com \
--cc=jasowang@redhat.com \
--cc=kernel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=namit@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).