From: Nathan Chancellor <nathan@kernel.org>
To: Joerg Roedel <jroedel@suse.de>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iommu/vt-d: Fix W=1 clang warning in intel/perf.c
Date: Thu, 17 Jun 2021 13:51:24 -0700 [thread overview]
Message-ID: <32f14288-315a-b75d-913b-2fc6a16cd748@kernel.org> (raw)
In-Reply-To: <YMuw+LtM/B1QTTJI@suse.de>
On 6/17/2021 1:30 PM, Joerg Roedel wrote:
> On Thu, Jun 17, 2021 at 10:16:50AM -0700, Nick Desaulniers wrote:
>> On Thu, Jun 17, 2021 at 7:54 AM Joerg Roedel <joro@8bytes.org> wrote:
>>>
>>> From: Joerg Roedel <jroedel@suse.de>
>>>
>>> Fix this warning when compiled with clang and W=1:
>>>
>>> drivers/iommu/intel/perf.c:16: warning: Function parameter or member 'latency_lock' not described in 'DEFINE_SPINLOCK'
>>> drivers/iommu/intel/perf.c:16: warning: expecting prototype for perf.c(). Prototype was for DEFINE_SPINLOCK() instead
>>
>> I think these warnings are actually produced by kernel-doc? (not clang)
>
> Will kernel-doc check automatically when COMPILER=clang is set and W=1?
> Because I did not explicitly enable any kernel-doc checks.
>
> Regards,
>
> Joerg
>
kernel-doc is run automatically with W=1, regardless of gcc versus clang.
Cheers,
Nathan
next prev parent reply other threads:[~2021-06-17 20:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 14:53 [PATCH] iommu/vt-d: Fix W=1 clang warning in intel/perf.c Joerg Roedel
2021-06-17 17:16 ` Nick Desaulniers
2021-06-17 20:30 ` Joerg Roedel
2021-06-17 20:51 ` Nathan Chancellor [this message]
2021-06-18 7:57 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32f14288-315a-b75d-913b-2fc6a16cd748@kernel.org \
--to=nathan@kernel.org \
--cc=baolu.lu@linux.intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ndesaulniers@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).