From: "AnilKumar, Chimata" <anilkumar@ti.com>
To: "axel.lin@gmail.com" <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"Girdwood, Liam" <lrg@ti.com>, "Nori, Sekhar" <nsekhar@ti.com>
Subject: RE: [PATCH RFT] regulator: tps65217: Convert to regulator_[is_enabled|get_voltage_sel]_regmap
Date: Mon, 18 Jun 2012 12:39:38 +0000 [thread overview]
Message-ID: <331ABD5ECB02734CA317220B2BBEABC13E9D84D9@DBDE01.ent.ti.com> (raw)
In-Reply-To: <CAF+7xWkh6CHvcur2iDs0Nwp_nO8i=6tYyTVauL6qtyrrMctjjA@mail.gmail.com>
Hi Axel,
Small correction in core file modification.
On Mon, Jun 18, 2012 at 17:25:59, Axel Lin wrote:
> > Basically regmap pointer is missed out in runtime configutaion data. Without this we
> > can see NULL pointer exception because config.regmap is NULL.
> >
> > + config.regmap = tps->regmap;
> >
> Since this patch is target for 3.6, this is not required.
> The regulator core will set it automatically.
> In drivers/regulator/core.c
> if (config->regmap)
> rdev->regmap = config->regmap;
> else
> rdev->regmap = dev_get_regmap(dev, NULL);
>
+ if (config->regmap)
+ rdev->regmap = config->regmap;
+ else
+ rdev->regmap = dev_get_regmap(dev->parent, NULL);
Regards
AnilKumar
next prev parent reply other threads:[~2012-06-18 12:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 3:27 [PATCH RFT] regulator: tps65217: Convert to regulator_[is_enabled|get_voltage_sel]_regmap Axel Lin
2012-06-13 9:09 ` AnilKumar, Chimata
2012-06-13 17:58 ` Mark Brown
2012-06-18 11:48 ` AnilKumar, Chimata
2012-06-18 11:55 ` Axel Lin
2012-06-18 12:01 ` Mark Brown
2012-06-18 12:05 ` AnilKumar, Chimata
2012-06-18 12:06 ` Axel Lin
2012-06-18 12:14 ` AnilKumar, Chimata
2012-06-18 12:39 ` AnilKumar, Chimata [this message]
2012-06-18 12:45 ` Mark Brown
2012-06-18 12:56 ` AnilKumar, Chimata
2012-06-18 13:09 ` Mark Brown
2012-09-07 14:19 ` AnilKumar, Chimata
2012-09-07 14:21 ` Mark Brown
2012-09-07 14:26 ` AnilKumar, Chimata
2012-09-07 14:30 ` Mark Brown
2012-09-07 14:38 ` AnilKumar, Chimata
2012-06-18 13:13 ` AnilKumar, Chimata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=331ABD5ECB02734CA317220B2BBEABC13E9D84D9@DBDE01.ent.ti.com \
--to=anilkumar@ti.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).